-
Notifications
You must be signed in to change notification settings - Fork 20
ci: declare FLAKY_BENCHMARKS_REGEX and document benchmarks CI #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9f3e9ca
ci: declare FLAKY_BENCHMARKS_REGEX and document benchmarks CI
igoragoli 3df0ffd
Merge branch 'main' into augusto/flaky-benchmarks-monitoring-docs
igoragoli 7ca83b8
docs: use permanent confluence links
igoragoli de81281
docs: improved wording for bench doc intro
igoragoli bf73099
docs: capitalized title
igoragoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # Benchmarks | ||
|
|
||
| This describes the GitLab CI configuration for the benchmarks that run on the | ||
| [Benchmarking Platform](https://datadoghq.atlassian.net/wiki/spaces/APMINT/pages/2419261562/Benchmarking+Platform). | ||
|
|
||
| ## Layout | ||
|
|
||
| - `benchmarks.yml`: Google Benchmark microbenchmarks. | ||
| - `benchmarks` clones `benchmarking-platform` (`dd-trace-cpp` branch), runs the benchmark, | ||
| converts and analyzes results, uploads and comments on the PR. | ||
| - `check-big-regressions` fails on regressions above the threshold defined on | ||
| `bp-runner.fail-on-regression.yml` in the `dd-trace-cpp` branch of | ||
| [benchmarking-platform](https://github.com/DataDog/benchmarking-platform). | ||
|
|
||
| ## Marking a Benchmark as Flaky | ||
|
|
||
| Add it to `FLAKY_BENCHMARKS_REGEX` in the `benchmarks` job's `variables` in `benchmarks.yml`. | ||
|
|
||
| The benchmark still runs and reports, but doesn't fail the gate. | ||
|
|
||
| - The regex matches anywhere in the scenario name. | ||
| - `BM_Trace` quarantines every scenario containing it, like `BM_TraceTinyCCSource`. | ||
| - Anchor with `^...$` to target one scenario. | ||
|
|
||
| ```yaml | ||
| FLAKY_BENCHMARKS_REGEX: "^BM_TraceTinyCCSource$" | ||
| ``` | ||
|
|
||
| Open a ticket to fix or remove it. See | ||
| [Flaky Benchmarks Monitoring](https://datadoghq.atlassian.net/wiki/x/dAKLrgE) for more details. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.