Skip to content

Support stable OTel deployment environment attribute - #9150

Merged
zacharycmontoya merged 3 commits into
masterfrom
brian.marks/otel-deployment-environment-name
Sep 18, 2026
Merged

Support stable OTel deployment environment attribute#9150
zacharycmontoya merged 3 commits into
masterfrom
brian.marks/otel-deployment-environment-name

Conversation

@bm1549

@bm1549 bm1549 commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Map deployment.environment.name to the Datadog environment. Keep deployment.environment as a fallback, and keep DD_ENV as the highest-precedence source.

Reason for change

OpenTelemetry stabilized the deployment environment semantic convention under deployment.environment.name.

Related PRs:

Implementation details

The resource attribute mapper tracks the stable and legacy values separately, then chooses the stable value regardless of input order. It removes both source aliases after promotion and leaves unrelated attributes alone.

Test coverage

Five focused mapping cases and 182 adjacent configuration tests passed locally. Formatting checks also passed.

Other details

None.

@bm1549 bm1549 added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Aug 28, 2026
This was referenced Aug 28, 2026
Draft
Draft
Open
Merged
Merged
Merged
@pr-commenter

pr-commenter Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-17 21:10:15

Comparing candidate commit 08968bc in PR branch brian.marks/otel-deployment-environment-name with baseline commit 309a802 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 11 performance regressions! Performance is the same for 61 metrics, 0 unstable metrics, 72 known flaky benchmarks, 54 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.290%; +9.300%]
  • 🟥 throughput [-33312.651op/s; -29471.771op/s] or [-9.383%; -8.301%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.939%; +8.950%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.009%; +9.021%]
  • 🟥 throughput [-32062.867op/s; -24049.717op/s] or [-7.925%; -5.944%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 allocated_mem [+295 bytes; +296 bytes] or [+10.163%; +10.175%]
  • 🟥 throughput [-10575.118op/s; -10104.974op/s] or [-12.072%; -11.536%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+9.052%; +9.064%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 allocated_mem [+191 bytes; +192 bytes] or [+7.267%; +7.279%]
  • 🟥 throughput [-12735.128op/s; -11481.555op/s] or [-10.106%; -9.111%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net472

  • 🟥 throughput [-7936.866op/s; -6995.576op/s] or [-6.080%; -5.359%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-14109.206op/s; -13135.185op/s] or [-16.729%; -15.574%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-9844.732op/s; -7276.691op/s] or [-8.275%; -6.116%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-12466.840op/s; -10869.823op/s] or [-12.676%; -11.052%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+1.573KB; +1.573KB] or [+47.789%; +47.804%]
  • 🟥 execution_time [+308.118ms; +310.385ms] or [+152.899%; +154.024%]
  • 🟥 throughput [-56.547op/s; -52.606op/s] or [-10.174%; -9.465%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 allocated_mem [+1.011KB; +1.011KB] or [+37.485%; +37.498%]
  • 🟥 execution_time [+375.584ms; +378.950ms] or [+296.734%; +299.394%]
  • 🟩 throughput [+72.000op/s; +75.065op/s] or [+9.493%; +9.897%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+1.090KB; +1.090KB] or [+40.417%; +40.429%]
  • 🟥 execution_time [+390.342ms; +395.791ms] or [+345.438%; +350.260%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+4.749KB; +4.749KB] or [+99.967%; +99.982%]
  • 🟥 throughput [-59871.451op/s; -59504.492op/s] or [-46.583%; -46.298%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.872KB; +3.872KB] or [+81.884%; +81.895%]
  • 🟩 execution_time [-16.051ms; -11.862ms] or [-7.496%; -5.540%]
  • 🟥 throughput [-61040.094op/s; -58281.418op/s] or [-44.556%; -42.542%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+4.600KB; +4.600KB] or [+99.468%; +99.481%]
  • 🟥 throughput [-49021.081op/s; -46746.980op/s] or [-44.321%; -42.265%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.372KB; +1.372KB] or [+111.007%; +111.023%]
  • 🟥 throughput [-286268.164op/s; -283523.945op/s] or [-29.229%; -28.949%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+535 bytes; +536 bytes] or [+43.787%; +43.796%]
  • 🟩 execution_time [-27.276ms; -22.432ms] or [-12.164%; -10.004%]
  • 🟥 throughput [-89965.232op/s; -67474.402op/s] or [-9.611%; -7.208%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.336KB; +1.336KB] or [+110.585%; +110.599%]
  • 🟥 throughput [-164782.129op/s; -148876.651op/s] or [-23.676%; -21.391%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • 🟥 allocated_mem [+3.378KB; +3.378KB] or [+89.003%; +89.017%]
  • 🟥 throughput [-72587.223op/s; -71823.155op/s] or [-48.850%; -48.336%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 allocated_mem [+3.336KB; +3.336KB] or [+88.150%; +88.161%]
  • 🟥 throughput [-75153.545op/s; -72275.464op/s] or [-47.819%; -45.988%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+3.264KB; +3.264KB] or [+88.493%; +88.506%]
  • 🟥 throughput [-56453.048op/s; -53814.555op/s] or [-44.972%; -42.870%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+244462.271op/s; +274020.950op/s] or [+8.151%; +9.137%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.949ms; -14.622ms] or [-8.735%; -6.740%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟩 allocated_mem [-13.759KB; -13.757KB] or [-42.326%; -42.318%]
  • 🟥 execution_time [+301.132ms; +302.425ms] or [+150.465%; +151.112%]
  • 🟩 throughput [+971.346op/s; +1004.232op/s] or [+10.728%; +11.092%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+299.539ms; +302.749ms] or [+151.058%; +152.677%]
  • 🟩 throughput [+2319.580op/s; +2543.215op/s] or [+17.741%; +19.452%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟩 allocated_mem [-13.722KB; -13.718KB] or [-42.341%; -42.329%]
  • 🟥 execution_time [+300.490ms; +303.073ms] or [+151.363%; +152.665%]
  • 🟩 throughput [+1903.561op/s; +2031.725op/s] or [+18.378%; +19.615%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.140ms; +297.733ms] or [+145.943%; +146.235%]
  • 🟩 throughput [+592.637op/s; +600.257op/s] or [+15.711%; +15.913%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+297.173ms; +298.666ms] or [+145.277%; +146.007%]
  • 🟩 throughput [+2784.670op/s; +2861.035op/s] or [+40.456%; +41.565%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.178ms; +302.026ms] or [+150.528%; +150.952%]
  • 🟩 throughput [+1371.957op/s; +1411.236op/s] or [+27.232%; +28.012%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • 🟩 execution_time [-145.567µs; -141.185µs] or [-29.887%; -28.987%]
  • 🟩 throughput [+842.158op/s; +872.481op/s] or [+41.017%; +42.494%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-128.801µs; -101.782µs] or [-29.541%; -23.344%]
  • 🟩 throughput [+755.963op/s; +884.576op/s] or [+32.866%; +38.458%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-142.991µs; -121.001µs] or [-30.636%; -25.925%]
  • 🟩 throughput [+780.144op/s; +862.883op/s] or [+36.013%; +39.832%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • 🟩 execution_time [-127.909µs; -123.931µs] or [-34.535%; -33.460%]
  • 🟩 throughput [+1369.871op/s; +1413.257op/s] or [+50.734%; +52.340%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-100.179µs; -76.559µs] or [-31.982%; -24.441%]
  • 🟩 throughput [+1139.225op/s; +1341.926op/s] or [+35.513%; +41.832%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • 🟩 execution_time [-137.735µs; -115.373µs] or [-37.679%; -31.561%]
  • 🟩 throughput [+1330.296op/s; +1466.020op/s] or [+47.739%; +52.610%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.759ms; +300.603ms] or [+149.611%; +150.032%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+262.338ms; +343.000ms] or [+285.041%; +372.684%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+324.153ms; +359.370ms] or [+246.127%; +272.867%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+298.022ms; +347.165ms] or [+137.028%; +159.623%]
  • 🟥 throughput [-540.526op/s; -498.853op/s] or [-48.977%; -45.201%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+138.035ms; +285.858ms] or [+58.825%; +121.821%]
  • 🟥 throughput [-672.429op/s; -588.762op/s] or [-44.851%; -39.271%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • unstable execution_time [+260.223ms; +314.874ms] or [+155.644%; +188.331%]
  • 🟥 throughput [-386.914op/s; -350.873op/s] or [-26.940%; -24.431%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-186.554µs; -135.879µs] or [-9.450%; -6.883%]
  • 🟩 throughput [+39.635op/s; +52.799op/s] or [+7.824%; +10.423%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+11.094%; +11.104%]
  • 🟥 execution_time [+302.007ms; +303.605ms] or [+152.085%; +152.890%]
  • 🟥 throughput [-21360.026op/s; -19821.605op/s] or [-6.873%; -6.378%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+300.689ms; +303.051ms] or [+150.676%; +151.859%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.101%; +11.112%]
  • 🟥 execution_time [+300.441ms; +304.861ms] or [+150.929%; +153.149%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.235%; +10.247%]
  • 🟥 execution_time [+302.545ms; +304.123ms] or [+151.928%; +152.720%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+11.451%; +11.465%]
  • 🟥 execution_time [+299.151ms; +300.752ms] or [+147.917%; +148.708%]
  • 🟥 throughput [-50641.905op/s; -44205.248op/s] or [-8.159%; -7.122%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+10.469%; +10.481%]
  • 🟥 execution_time [+303.447ms; +307.273ms] or [+153.800%; +155.739%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 allocated_mem [+88 bytes; +89 bytes] or [+10.268%; +10.280%]
  • 🟥 execution_time [+302.263ms; +305.311ms] or [+151.709%; +153.238%]
  • 🟥 throughput [-32776.419op/s; -30543.087op/s] or [-8.503%; -7.924%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+301.482ms; +304.273ms] or [+150.261%; +151.652%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+9.730%; +9.743%]
  • 🟥 execution_time [+299.211ms; +302.920ms] or [+148.855%; +150.700%]
  • 🟥 throughput [-29252.056op/s; -24235.111op/s] or [-6.924%; -5.737%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.444%; +5.452%]
  • 🟥 throughput [-18697.944op/s; -16704.598op/s] or [-7.519%; -6.717%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.160%; +5.169%]
  • 🟩 execution_time [-17.420ms; -13.771ms] or [-8.100%; -6.403%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.136%; +5.148%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+10.929µs; +54.186µs] or [+2.699%; +13.384%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-18.732KB; -18.708KB] or [-6.833%; -6.824%]
  • unstable execution_time [-26.337µs; +31.664µs] or [-5.205%; +6.258%]
  • unstable throughput [-113.569op/s; +88.058op/s] or [-5.667%; +4.394%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-18.559KB; -18.540KB] or [-6.766%; -6.759%]
  • unstable execution_time [-68.376µs; -6.793µs] or [-11.849%; -1.177%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+6.614µs; +10.829µs] or [+15.633%; +25.596%]
  • 🟥 throughput [-4937.062op/s; -3148.562op/s] or [-20.783%; -13.254%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.301µs; -6.869µs] or [-22.188%; -10.657%]
  • 🟩 throughput [+1672.778op/s; +3274.013op/s] or [+10.263%; +20.087%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.440ms; +303.982ms] or [+152.870%; +153.650%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+307.049ms; +310.364ms] or [+156.287%; +157.974%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.181ms; +305.453ms] or [+150.778%; +152.917%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.432%; +8.443%]
  • 🟥 throughput [-34544.077op/s; -32579.075op/s] or [-9.563%; -9.019%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.467%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+8.456%; +8.466%]
  • 🟥 throughput [-34971.448op/s; -25748.918op/s] or [-8.277%; -6.094%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+296.370ms; +298.290ms] or [+147.714%; +148.671%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 allocated_mem [+88 bytes; +88 bytes] or [+5.502%; +5.512%]
  • 🟥 execution_time [+300.699ms; +302.359ms] or [+150.997%; +151.830%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+5.333%; +5.343%]
  • 🟥 execution_time [+302.933ms; +305.156ms] or [+153.628%; +154.755%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.548ms; +301.888ms] or [+149.915%; +150.583%]
  • 🟩 throughput [+65793996.177op/s; +66159037.385op/s] or [+47.915%; +48.181%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+417.224ms; +421.874ms] or [+518.892%; +524.675%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.430ms; +300.404ms] or [+149.349%; +149.835%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • 🟥 throughput [-52215.423op/s; -47413.781op/s] or [-5.827%; -5.291%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • 🟥 throughput [-65949.104op/s; -61807.909op/s] or [-6.037%; -5.658%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-15.325ms; +7.235ms] or [-7.984%; +3.769%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+37719.416op/s; +44781.154op/s] or [+6.849%; +8.131%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+14.421%; +14.433%]
  • 🟥 throughput [-108809.457op/s; -104130.696op/s] or [-15.925%; -15.240%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.589%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • 🟥 allocated_mem [+87 bytes; +88 bytes] or [+13.576%; +13.587%]
  • 🟥 throughput [-95626.167op/s; -73045.188op/s] or [-13.352%; -10.199%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (9150) and master.

✅ No regressions detected

📄 View the full report (charts + all metrics) →

@bm1549 bm1549 added the docker_image_artifacts Use to label PRs for which you would need a Docker Image created for. label Aug 28, 2026
@bm1549
bm1549 marked this pull request as ready for review September 1, 2026 22:49
@bm1549
bm1549 requested review from a team as code owners September 1, 2026 22:49
@bm1549
bm1549 requested review from zacharycmontoya and removed request for a team September 1, 2026 22:49
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-01T22:52:09.110356Z 5b35083 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-01T22:52:47.846070Z 5b35083 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

bouwkast
bouwkast reviewed Sep 2, 2026
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Configuration/MutableSettings.cs Outdated
@zacharycmontoya

zacharycmontoya commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

There are going to be some small merge conflicts so let's wait to include this after the next release, when we'll re-incorporate Milan's tracestate work

@zacharycmontoya
zacharycmontoya force-pushed the brian.marks/otel-deployment-environment-name branch from 2902519 to 08968bc Compare September 17, 2026 20:04
zacharycmontoya
zacharycmontoya approved these changes Sep 18, 2026
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the improvement, but I also added a commit to this PR so does it count?

@zacharycmontoya
zacharycmontoya merged commit 9c8d091 into master Sep 18, 2026
146 checks passed
@zacharycmontoya
zacharycmontoya deleted the brian.marks/otel-deployment-environment-name branch September 18, 2026 14:33
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos docker_image_artifacts Use to label PRs for which you would need a Docker Image created for.

Projects

None yet

Milestone

3.54.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bm1549 @zacharycmontoya @bouwkast