Conversation
bm1549
added
the
AI Generated
Contributor
Config Audit |
This was referenced Aug 28, 2026
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c6a0d7d | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-10-02 19:15:28 Comparing candidate commit c6a0d7d in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 339 metrics, 1 unstable metrics, 1 flaky benchmarks without significant changes.
|
zacharycmontoya
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Sep 18, 2026
## Summary of changes Map `deployment.environment.name` to the Datadog environment. Keep `deployment.environment` as a fallback, and keep `DD_ENV` as the highest-precedence source. ## Reason for change OpenTelemetry stabilized the deployment environment semantic convention under `deployment.environment.name`. Related PRs: - DataDog/system-tests#7613 - DataDog/dd-trace-go#5285 - #9150 - DataDog/dd-trace-rb#6261 - DataDog/dd-trace-php#4148 - DataDog/dd-trace-js#10050 - DataDog/dd-trace-rs#300 - DataDog/dd-trace-java#12324 - DataDog/dd-trace-py#19901 ## Implementation details The resource attribute mapper tracks the stable and legacy values separately, then chooses the stable value regardless of input order. It removes both source aliases after promotion and leaves unrelated attributes alone. ## Test coverage Five focused mapping cases and 182 adjacent configuration tests passed locally. Formatting checks also passed. ## Other details None. --------- Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com>
bm1549
marked this pull request as ready for review
October 2, 2026 16:48
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d620f3060
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maps
deployment.environment.nametoenv, withdeployment.environmentas a fallback. Traces and OpenTelemetry metrics now use the same order:DD_ENV,DD_TAGS[env], the stable OTel attribute, then the legacy OTel attribute.For duplicate OTel attributes, the final value wins. An empty final stable value falls through to the legacy attribute. A generic
envresource attribute is used only when neither semantic attribute resolves.Motivation
OpenTelemetry stabilized the deployment environment semantic convention under
deployment.environment.name.Related PRs:
Reviewer's Checklist
make lintlocally.make testlocally.make generatelocally.make fix-moduleslocally.Unsure? Have a question? Request a review!