Add atomic runtime execution for augmented PickUp collection - #594
Draft
yuecideng wants to merge 1 commit into
Draft
Add atomic runtime execution for augmented PickUp collection#594yuecideng wants to merge 1 commit into
yuecideng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Execute selected augmented PickUp candidates through a fresh
ExecutionSessionandExecutionRunner, with measured arm feedback and verified held-object effects before expert-data acceptance. The existing collector previously replayed offline atomic templates;cube_pickup_collection.py --runtimenow exercises the observed runtime while preserving its physical contact checks and confirmed LeRobot persistence.Depends on #591. This is a separate increment based on
feat/fixed-scene-trajectory-generation; review only the changes above that branch.PickUpRuntimeSourceand share plan/effect construction throughPickUp.materialize_trajectory. Preserve the chosen joint branch and transit/approach/close/lift/hold phases after every full-batch initial-state restoration.This layer covers Atomic PickUp × pure simulation with the existing fixed-base URDF / cuboid / CPU-physics contact profile. Contact-aware Gym, general via-point factors, the unified YAML launcher and the complete M1 qualification matrix remain subsequent work.
Type of change
Validation
black .,black --check .,git diff --check, API coverage 1762/1762, and docs checker 8 passed. Sphinx dummy build succeeded with 744 warnings; none referenced the added generation APIs. Independent read-only review findings were fixed and rechecked.Screenshots
Reproduce the synchronized four-panel video and numeric dataset:
The output directory must be new or empty.
preview.mp4shows two grasp orientations and independent augmented transit paths;generation_report.jsonand per-episode metadata carry acceptance evidence. Video is separate from the numeric LeRobot dataset.Checklist
black .command to format the code base.