Fix atomic tutorial startup and obstacle recovery - #618
Conversation
Clear current articulation velocities during resets, reduce tutorial sun intensity, and prevent the animated planning obstacle from physically knocking the robot over while preserving planner collision geometry. Adjust short-path triggering and add focused regression coverage.
|
| assert "fit_type=" not in main_source | ||
| assert "sphere_density=COLLISION_SPHERE_FIT_DENSITY" in main_source | ||
| assert "collision_sphere_buffer=ROBOT_COLLISION_BUFFER" in main_source | ||
| assert "RigidBodyAttributesCfg(enable_collision=False)" in main_source |
There was a problem hiding this comment.
Collision Behavior Is Untested
This test only checks that main contains the literal RigidBodyAttributesCfg(enable_collision=False). It will still pass if collision-disabled objects later stop contributing geometry to cuRobo or stop producing scene revisions, even though the fix depends on both behaviors. Add a functional test that constructs a collision-disabled obstacle and verifies its inclusion in the cuRobo world and its pose-update/replanning path.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/sim/atomic_actions/test_tutorial_utils.py
Line: 1060
Comment:
**Collision Behavior Is Untested**
This test only checks that `main` contains the literal `RigidBodyAttributesCfg(enable_collision=False)`. It will still pass if collision-disabled objects later stop contributing geometry to cuRobo or stop producing scene revisions, even though the fix depends on both behaviors. Add a functional test that constructs a collision-disabled obstacle and verifies its inclusion in the cuRobo world and its pose-update/replanning path.
**Knowledge Base Used:**
- [Simulation lab](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/simulation-lab.md)
- [Motion planning and kinematics](https://app.greptile.com/dexforce/-/custom-context/knowledge-base/dexforce/embodichain/-/docs/motion-planning-and-kinematics.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
This PR fixes the atomic-action tutorial startup and dynamic-obstacle recovery behavior.
No external dependencies are required. No issue number was provided for linking.
Type of change
Validation
Preview video generated at outputs/videos/dynamic_obstacle_recovery_auto_play_2026-09-12-08-02-24.mp4.
Checklist