Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the inherited SVG
clip-ruleproperty for Servo (remove the Gecko-only restriction) and mark changes asrepaint. This lets consumers cascadenonzero/evenoddthrough ordinary CSS rather than reparsing the property themselves.The same two-line change was tested against Stylo 0.22.0 in Blitz's pixel/cascade/restyling regressions. DioxusLabs'
mainis still on 0.20.0, so this PR keeps its diff focused; Blitz temporarily pins the equivalent patch on 0.22.0 atbdc4fe7.Companion renderer change: DioxusLabs/anyrender#105
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e0ae5a7e77b4472fa049798331653054
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e0ae5a7e77b4472fa049798331653054?variant=devin-insiders
Requested by: @nicoburns