Fix procedural skybox orientation in orthographic cameras - #622
Merged
DoubleStyx merged 2 commits intoJun 4, 2026
Merged
Conversation
Baplar
commented
Jun 4, 2026
| let camera_ray = view_ray.xy / (-view_ray.z); | ||
| if (orthographic) { | ||
| return vec4<f32>(sign(view_ray.xy * proj_params.xy), 0.0, 1.0); | ||
| return vec4<f32>(camera_ray * sign(proj_params.xy), 0.0, 1.0); |
Collaborator
Author
There was a problem hiding this comment.
There was a discrepancy with Unity in the way all skyboxes got rendered in ortho cameras, this change seems to bring it up to parity, along with the change in the common module
Baplar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caused by the view ray being double-flipped in offscreen views.
It’s flipped once already in skybox::ndc_from_fragment_position, but we incorrectly flipped it a second time in clip_pos_from_view_ray