Preserve vision credential bindings and channel hint contract - #457
Closed
FerroxLabs wants to merge 5 commits into
Closed
FerroxLabs wants to merge 5 commits into
FerroxLabs wants to merge 5 commits into
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop mirrors the selected custom-provider key into
OPENAI_API_KEY; vision previously chose OpenAI’s native endpoint before consulting that provider. Keep matching credentials paired with their configured destination, including whitespace variants, and fail closed for malformed or unsupported matching bindings. Preserve independent native OpenAI credentials, explicit Anthropic precedence, model overrides and accounting.Also align the untrusted-channel directive and independent wire oracle with the existing “Experimental skill hint:” producer label. The wire fixture now creates and explicitly selects a project-local skill and asserts its actual hint reaches the provider, so the regression is exercised on a clean host. Strict sender-byte, forged-marker, unknown-block and system-role controls remain.
Necessary ledger reconciliation preserves #455’s existing grading across its byte-identical squash (
28634521and1780b316, tree90e028ae6de0537c60c1d86450ceb3083ae4610b). Five lost ancestry anchors are repinned, and existing #1116/#443 unresolved dispositions remain not met. No acceptance gate, signing policy, tag or release is changed.Validation on exact
c98b58c6ef0c028c4830bd62a10712c560b930b1:just push: workspace Clippy with warnings denied, formatting, complete preflight, and full nextest 18,071 passed, 104 skipped. DedicatedWAYLAND_HOMEprevents host-installed skills/credentials contaminating the fixtures.cf196abc1ddd4ee30ffa7385d003260eb98c63bae0a5b49a85e45429ad20b737. Development build only; native report and final signed-release qualification remain separate.Related coordination: FerroxLabs/wayland#1324. Desktop consumer PR: FerroxLabs/wayland#1348.