fix(desktop): retain skills and reuse release artifacts - #1348
Draft
FerroxLabs wants to merge 4 commits into
Draft
FerroxLabs wants to merge 4 commits into
FerroxLabs wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1347.
Intel DMG packaging exhausted the destination image, omitted Electron Framework and retried the same failed copy three times. The workflow now budgets filesystem overhead, verifies copy integrity and saves the signed/notarized app ZIP before DMG work. A failed packaging job can reuse that verified checkpoint from the same producer and exact source without rebuilding or notarizing the app again.
Checkpoint admission verifies the GitHub artifact digest before extraction and binds repository, run, source, architecture, version, signing identity and content hashes. ZIP bytes and updater metadata are preserved. Failed-job retry instructions replace the producer's broken self-rerun; draft uploads skip identical assets and refuse replacement bytes. Existing protected installer, updater, final acceptance and publication gates remain required.
The pending masterclass candidate bundles TVControl 2.5.3 with its exact integrity pin, managed upgrades and 113-tool fixture. An early native Core MCP probe detects the Windows spaced-executable launcher failure before packaging.
Imported skills previously disappeared from the picker after restart because registration was memory-only, while their installed directories still caused duplicate-import rejection. Completed imports now persist in app-owned configuration, with input hashes, consent evidence and fresh guard checks at startup. Identical legacy reimports use the existing consent flow without overwriting files; different content remains refused. Import-provider failures now return typed errors so the dialog displays the failure and clears its loading state.
Validation:
Keep draft and unmerged: official Core bundle pins remain 0.13.12 pending the publisher's corrected release. Matching development Core contract import is isolated outside this branch; final published binaries/features/manifest still require normal admission. The full Windows report remains unaccepted, Core provider qualification is outstanding, and development-app Mac normal quit needs disposition. Same-producer CI retry, immutable live upload and final signed installer/update gates remain unproven. This PR has not published a Desktop release.