Properly Multi-target Roslyn

[viceroypenguin]

Summary by CodeRabbit

• Compatibility

  • Updated package builds to support Roslyn 4.8, 5.0, and 5.9 across the supported .NET targets.
  • Removed .NET 9.0 from the supported target framework list.
  • Improved compatibility for analyzer, code-fix, and source-generator packages across supported compiler versions.

• Packaging

  • Added package validation against the 3.0.0 baseline.
  • Updated analyzer dependencies and package metadata for newer compiler environments.

• Tests

  • Updated functional and compatibility coverage for the supported .NET and Roslyn combinations.

[coderabbitai]

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c4ea81e4-bdf9-4169-8295-23ef2f46ea71

📥 Commits

Reviewing files that changed from the base of the PR and between d5ec6d9 and 6fd4f85.

📒 Files selected for processing (2)

• .github/workflows/build.yml
• .github/workflows/release.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0cffe07f-033b-4b2c-a3d7-e7ceabefc215

📥 Commits

Reviewing files that changed from the base of the PR and between 322b4b3 and d5ec6d9.

📒 Files selected for processing (11)

• Directory.Build.props
• Directory.Packages.props
• src/Immediate.Validations.Analyzers/Immediate.Validations.Analyzers.csproj
• src/Immediate.Validations.CodeFixes/Immediate.Validations.CodeFixes.csproj
• src/Immediate.Validations.Generators/Immediate.Validations.Generators.csproj
• src/Immediate.Validations.Shared/Immediate.Validations.Shared.csproj
• src/Immediate.Validations/CompatibilitySuppressions.xml
• src/Immediate.Validations/Immediate.Validations.csproj
• tests/Immediate.Validations.FunctionalTests/Immediate.Validations.FunctionalTests.csproj
• tests/Immediate.Validations.FunctionalTests/Resources/Validators.Designer.cs
• tests/Immediate.Validations.Tests/Immediate.Validations.Tests.csproj

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The build removes net9.0 and introduces Roslyn-specific targets for analyzer, code-fix, and generator projects. Package assets and test references now select Roslyn 4.8, 5.0, or 5.9 per target framework.

Changes

Roslyn-targeted build and packaging

Layer / File(s)	Summary
Framework and package target definitions Directory.Build.props, Directory.Packages.props	The build targets net8.0, net10.0, and net11.0. Package conditions now support Roslyn 4.8, 5.0, and 5.9.
Roslyn-specific analyzer project targets src/Immediate.Validations.Analyzers/Immediate.Validations.Analyzers.csproj, src/Immediate.Validations.CodeFixes/Immediate.Validations.CodeFixes.csproj, src/Immediate.Validations.Generators/Immediate.Validations.Generators.csproj	Analyzer, code-fix, and generator projects target Roslyn-specific frameworks. The generator uses target-specific Scriban handling.
Roslyn-specific project wiring and package assets src/Immediate.Validations.Shared/Immediate.Validations.Shared.csproj, src/Immediate.Validations/Immediate.Validations.csproj, src/Immediate.Validations/CompatibilitySuppressions.xml	Project references select Roslyn targets per framework. Package validation and Roslyn-specific assembly packaging are configured.
Roslyn-specific test project wiring tests/Immediate.Validations.FunctionalTests/*, tests/Immediate.Validations.Tests/Immediate.Validations.Tests.csproj	Tests build analyzer projects for the matching Roslyn target and reference the resulting assemblies. Resource metadata and test project settings are updated.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to d5ec6

This change replaces generic analyzer builds with Roslyn-version-specific assets for the supported frameworks. The supplied configuration and test wiring are consistent, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: configuring the projects to multi-target Roslyn versions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch multi-target-roslyn

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coveralls]

Coverage Report for CI Build 34402458522

Coverage remained the same at 88.337%

Details

• Coverage remained the same as the base build.
• Patch coverage: No coverable lines changed in this PR.
• No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	2255
Covered Lines:	1992
Line Coverage:	88.34%
Coverage Strength:	2.65 hits per line

---

💛 - Coveralls