Skip to content

Properly Multi-target Roslyn #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viceroypenguin merged 2 commits into from
Sep 9, 2026
Merged

Properly Multi-target Roslyn #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ec6d9
Properly Multi-target Roslyn
viceroypenguin Sep 9, 2026
6fd4f85
Fix build
viceroypenguin Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:

steps:
- uses: actions/checkout@v7
with:
fetch-depth: '0'

- name: Setup .NET
uses: actions/setup-dotnet@v6
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,18 @@ jobs:
dotnet-version: |
11.0.x

- name: Restore tools
run: dotnet tool restore

- name: Restore dependencies
run: dotnet restore
- name: Build
run: dotnet build -c Release --no-restore

- name: Package
run: dotnet pack -c Release --no-build --property:PackageOutputPath=../../nupkgs
- name: Validate Package
run: dotnet tool run dotnet-validate -- package local ./nupkgs/*.nupkg

- name: NuGet login (OIDC → temp API key)
uses: NuGet/login@v1
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup>
<TargetFrameworks>net8.0;net9.0;net10.0;net11.0</TargetFrameworks>
<TargetFrameworks>net8.0;net10.0;net11.0</TargetFrameworks>
<LangVersion>latest</LangVersion>

<Nullable>enable</Nullable>
Expand Down
23 changes: 4 additions & 19 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,9 @@
<PackageVersion Include="Microsoft.Extensions.Localization.Abstractions" Version="8.0.30" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net9.0' ">
<PackageVersion Include="Basic.Reference.Assemblies.Net90" Version="1.8.11" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.20" />
<PackageVersion Include="Microsoft.Extensions.Localization" Version="9.0.20" />
<PackageVersion Include="Microsoft.Extensions.Localization.Abstractions" Version="9.0.20" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net10.0' ">
<PackageVersion Include="Basic.Reference.Assemblies.Net100" Version="1.8.11" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.300" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.400" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="10.0.11" />
<PackageVersion Include="Microsoft.Extensions.Localization" Version="10.0.11" />
<PackageVersion Include="Microsoft.Extensions.Localization.Abstractions" Version="10.0.11" />
Expand All @@ -51,35 +43,28 @@
</ItemGroup>

<!-- IV.Generators dependencies -->
<ItemGroup Condition=" '$(TargetFramework)' == 'net11.0' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net11.0' or '$(TargetFramework)' == 'roslyn5.9' ">
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="5.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.9.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="5.9.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net10.0' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'net10.0' or '$(TargetFramework)' == 'roslyn5.0' ">
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="5.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="5.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="5.0.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net9.0' ">
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.12.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.12.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.12.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.12.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'net8.0' ">
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="4.11.0" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
<ItemGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.8.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
Expand Down
20 changes: 19 additions & 1 deletion src/Immediate.Validations.Analyzers/Immediate.Validations.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net10.0</TargetFrameworks>
<TargetFrameworks>roslyn4.8;roslyn5.0;roslyn5.9</TargetFrameworks>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<IsRoslynComponent>true</IsRoslynComponent>
</PropertyGroup>
Expand All @@ -15,4 +15,22 @@
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.0' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.9' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

</Project>
20 changes: 19 additions & 1 deletion src/Immediate.Validations.CodeFixes/Immediate.Validations.CodeFixes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks>roslyn4.8;roslyn5.0;roslyn5.9</TargetFrameworks>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<IsRoslynComponent>true</IsRoslynComponent>
</PropertyGroup>
Expand All @@ -17,4 +17,22 @@
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.0' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.9' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

</Project>
38 changes: 35 additions & 3 deletions src/Immediate.Validations.Generators/Immediate.Validations.Generators.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net10.0</TargetFrameworks>
<TargetFrameworks>roslyn4.8;roslyn5.0;roslyn5.9</TargetFrameworks>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<IsRoslynComponent>true</IsRoslynComponent>
<NoWarn>$(NoWarn);CA1716</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand All @@ -19,17 +20,48 @@
<PackageReference Include="AssemblyMetadata.Generators" PrivateAssets="All" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" />
</ItemGroup>

<!-- Scriban (code in netstandard2.0; lib in net10+) -->
<ItemGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<PackageReference Include="Scriban" PrivateAssets="all" IncludeAssets="Build" />
</ItemGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<PackageScribanIncludeSource>true</PackageScribanIncludeSource>
<DefineConstants>$(DefineConstants);SCRIBAN_NO_ASYNC</DefineConstants>
</PropertyGroup>

<ItemGroup Condition=" '$(TargetFramework)' != 'roslyn4.8' ">
<PackageReference Include="Scriban" PrivateAssets="all" GeneratePathProperty="true" />
</ItemGroup>

<PropertyGroup>
<PropertyGroup Condition=" '$(TargetFramework)' != 'roslyn4.8' ">
<GetTargetPathDependsOn>$(GetTargetPathDependsOn);GetDependencyTargetPaths</GetTargetPathDependsOn>
</PropertyGroup>

<Target Name="GetDependencyTargetPaths">
<Target Name="GetDependencyTargetPaths" Condition=" '$(TargetFramework)' != 'roslyn4.8' ">
<ItemGroup>
<TargetPathWithTargetPlatformMoniker Include="$(PkgScriban)/lib/netstandard2.0/Scriban.dll" IncludeRuntimeDependency="false" />
</ItemGroup>
</Target>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn4.8' ">
<TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETStandard,Version=v2.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.0' ">
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v10.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETCoreApp,Version=v10.0</TargetFrameworkMoniker>
</PropertyGroup>

<PropertyGroup Condition=" '$(TargetFramework)' == 'roslyn5.9' ">
<TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier>
<TargetFrameworkVersion>v10.0</TargetFrameworkVersion>
<TargetFrameworkMoniker>.NETCoreApp,Version=v10.0</TargetFrameworkMoniker>
</PropertyGroup>

</Project>
21 changes: 16 additions & 5 deletions src/Immediate.Validations.Shared/Immediate.Validations.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">

<ItemGroup>
<ProjectReference Include="../Immediate.Validations.Analyzers/Immediate.Validations.Analyzers.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
<ProjectReference Include="../Immediate.Validations.CodeFixes/Immediate.Validations.CodeFixes.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Immediate.Handlers" PrivateAssets="all" />
<PackageReference Include="Microsoft.Extensions.Localization.Abstractions" />
Expand All @@ -14,4 +9,20 @@
<InternalsVisibleTo Include="Immediate.Validations.FunctionalTests" />
</ItemGroup>

<PropertyGroup>
<RoslynVersion Condition=" '$(TargetFramework)' == 'net8.0' ">roslyn4.8</RoslynVersion>
<RoslynVersion Condition=" '$(TargetFramework)' == 'net10.0' ">roslyn5.0</RoslynVersion>
<RoslynVersion Condition=" '$(TargetFramework)' == 'net11.0' ">roslyn5.9</RoslynVersion>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="../../src/Immediate.Validations.Analyzers/Immediate.Validations.Analyzers.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false">
<SetTargetFramework>TargetFramework=$(RoslynVersion)</SetTargetFramework>
</ProjectReference>

<ProjectReference Include="../../src/Immediate.Validations.CodeFixes/Immediate.Validations.CodeFixes.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false">
<SetTargetFramework>TargetFramework=$(RoslynVersion)</SetTargetFramework>
</ProjectReference>
</ItemGroup>

</Project>
46 changes: 46 additions & 0 deletions src/Immediate.Validations/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.IsExternalInit</Target>
<Left>lib/net10.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net10.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.RequiresLocationAttribute</Target>
<Left>lib/net10.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net10.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.IsExternalInit</Target>
<Left>lib/net8.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net8.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.RequiresLocationAttribute</Target>
<Left>lib/net8.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net8.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.IsExternalInit</Target>
<Left>lib/net9.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net8.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:System.Runtime.CompilerServices.RequiresLocationAttribute</Target>
<Left>lib/net9.0/Immediate.Validations.Shared.dll</Left>
<Right>lib/net8.0/Immediate.Validations.Shared.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
Loading