Combine the open compat updates - #4
Merged
Merged
Conversation
Widen two `[compat]` bounds instead of moving them: SimpleSolvers to "0.11, 0.13" and GeometricProblems to "0.8, 0.9". This is the union of the two open CompatHelper pull requests, #1 and #2, in one branch. The explanatory comments above the `[compat]` entries are kept byte-identical; CompatHelper's own diffs delete them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility changes are documented and have no unresolved review issues.
Pull request overview
Combines compatibility updates for SimpleSolvers and GeometricProblems while preserving existing supported versions.
Changes:
- Adds compatibility with
SimpleSolvers 0.13andGeometricProblems 0.9. - Documents the updates in the changelog.
File summaries
| File | Description |
|---|---|
Project.toml |
Widens both compatibility entries. |
CHANGELOG.md |
Records the compatibility updates. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines the two open CompatHelper pull requests into one branch, so the matrix runs once against both new bounds.
[compat]before[compat]after"0.11""0.11, 0.13""0.8""0.8, 0.9"Both bounds widen rather than move, so an environment that resolved the older pair still resolves.
CompatHelper's own diffs delete the explanatory comments above several
[compat]entries. This branch keeps every one of them byte-identical, and touches no[deps]entry.One comment to check: the note above
GeometricIntegratorssays the three solver bounds move together and that GeometricIntegratorsBase 0.6 requires SimpleSolvers 0.11. That sentence describes the lower end of the range, which is unchanged. Whether GeometricIntegratorsBase 0.6 also accepts SimpleSolvers 0.13 is a question for the resolver, and CI answers it here. The comment was not rewritten.The test suite was not run locally. CI is the check.
Closes #1
Closes #2
🤖 Generated with Claude Code