Conversation
michalpelka
requested changes
Sep 13, 2026
michalpelka
left a comment
michalpelka
left a comment
Contributor
There was a problem hiding this comment.
I please modify CI and release code for Windows to perform full build.
I assume that should improve experience for users who builds from source.
mwlasiuk
marked this pull request as ready for review
September 14, 2026 18:46
michalpelka
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables building tools and applications that do not belong to core workflow described in file images/workflow.png and disables build of core_no_gui if no project that uses it is built (pybind and lidar odometry test).