[Fix] Hold DMA AXI address valid until ready - #33
Open
flaviens wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the DMA AXI address-channel handshake behavior to avoid potential deadlock with conforming AXI targets by asserting address VALID independent of READY and holding it until the handshake completes.
Changes:
- Write engine: stop waiting for
AWREADYbefore issuing a write address request; assertAWVALIDinSEND_WR_REQuntilAWREADYhandshakes. - Read engine: stop waiting for
ARREADYbefore assertingARVALID; remain inSEND_RD_REQuntilARREADYhandshakes before advancing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tutorial/afu_types/01_pim_ifc/dma/hw/rtl/dma_write_engine.sv | Removes AWREADY gating in IDLE and asserts AWVALID unconditionally in the request state until handshake. |
| tutorial/afu_types/01_pim_ifc/dma/hw/rtl/dma_read_engine.sv | Removes ARREADY gating prior to request, and holds in request state until ARREADY completes the handshake. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue AXI read and write addresses without waiting for READY. Waiting first can deadlock against a conforming target; each VALID now remains asserted until its handshake.
Collateral (docs, reports, design examples, case IDs):
None.
Tests added:
Directed external RTL regression with READY asserted three cycles after VALID.
Tests run:
Verilator end-to-end DMA engine test: source read through the data FIFO to one destination write.