prevent KeyError when wiki file does not exist in download fallback#128
Merged
Conversation
When the MediaWiki FileApi returns download-notfound, the exception raised inside the try block was silently caught by the broad `except Exception`, setting web_api_failed=True. The subsequent fallback then crashed with KeyError: 'url' because the file's imageinfo has no URL for non-existent files. Fix by using a flag instead of raising inside the try block.
Adds */accounts.pwd.yaml to prevent credential files from being staged, and removes the duplicate */osw_files/* entry that was auto-appended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the MediaWiki FileApi returns download-notfound, the exception raised
inside the try block was silently caught by the broad
except Exception,setting web_api_failed=True. The subsequent fallback then crashed with
KeyError: 'url' because the file's imageinfo has no URL for non-existent
files. Fix by using a flag instead of raising inside the try block.