Skip to content

prevent KeyError when wiki file does not exist in download fallback #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasGold merged 2 commits into from
Jul 7, 2026
Merged

prevent KeyError when wiki file does not exist in download fallback #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e43f221
fix: prevent KeyError when wiki file does not exist in download fallback
LukasGold Jun 16, 2026
62868a7
chore: ignore accounts.pwd.yaml and remove duplicate gitignore entry
LukasGold Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,5 @@ playground

# Automatically added by osw.auth.CredentialManager.save_credentials_to_file:
*/osw_files/*

*/accounts.pwd.yaml
5 changes: 4 additions & 1 deletion src/osw/controller/file/wiki.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def get(self) -> IO:
# use web api
full_title = f"{self.namespace}:{self.title}"
web_api_failed = False
file_not_found = False
response = None
try:
url = (
Expand All @@ -54,7 +55,7 @@ def get(self) -> IO:
if api_error is not None:
if api_error == "download-notfound":
# File does not exist
raise Exception("File does not exist: " + full_title)
file_not_found = True
elif api_error == "badvalue":
# Extension FileApi not installed on the server
web_api_failed = True
Expand All @@ -64,6 +65,8 @@ def get(self) -> IO:

except Exception:
web_api_failed = True
if file_not_found:
raise Exception("File does not exist: " + full_title)
if web_api_failed:
# fallback: use direct download
url = file.imageinfo["url"]
Expand Down
Loading