AOT: skip zero-byte helper-runtime unit.o — hash_hmac_algos link (#6229) - #35576
Merged
Conversation
Interrupted emit can leave an empty build-cache unit.o that shadows the committed prelinked object; AOT then links no helper body and hash_hmac_algos (array_is_list) fails with undefined ArrayIsListJitHelper symbols (#6229). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 28, 2026
…low-up). (#35579) #35574 added JitMbGetInfo, MbGetInfoJitHelper, and MbGetInfoRuntime to the compile spine but left duplicate require_once lines (7965/7962). Remove the three extras so spine-count-sync reports 7962/7962 again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HelperRuntimeCache::unitObjectIsLinkable()rejectsunit.ofiles withfilesize() === 0.helperIndex()andlinkObjects()use it so interrupted emit artifacts do not shadow committed prelinked helper objects.undefined reference to PHPCompiler_ext_standard_ArrayIsListJitHelper__islistinhash_hmac_algosfixture (array_is_listbridge).Root cause
build/helper-runtime-cache/units/ext_standard_ArrayIsListJitHelper_php/unit.owas 0 bytes while manifest/bc looked fresh. Build cache outranks prelinked inhelperIndex(), sotryProvidebound an extern declaration but linked an empty object.Test plan
Relates #6229 / #15889
Made with Cursor