Conversation
Updates laps to support the new changes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b85b3e67b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| s_attrs.new_group_request_id = | ||
| parameters.GetOptional<bool>(quicr::messages::ParameterType::kNewGroupRequest); |
There was a problem hiding this comment.
For peer subscribe data that contains kNewGroupRequest with an actual group id (for example 123), reading it as bool converts the value to true and then assigns 1 into s_attrs.new_group_request_id. The downstream ProcessSubscribe/logs use that id to request the new group, so relayed peer subscriptions will request group 1 instead of the group carried on the wire; this should use the already-parsed uint64_t value.
Useful? React with 👍 / 👎.
RichLogan
left a comment
RichLogan
left a comment
There was a problem hiding this comment.
Couple very minor things but looks good
* Change to support header changes * Add subscribe and publish handler metrics
NS -> Tracks
Stop log wrap
…be tracks and subscribe matching
# Conflicts: # src/relay_health_check.cpp
Also rebuild on new track
Accumulate stream buffer
Add metrics exporter
Top-N immediate evict
3 participants
No description provided.