feat(browse): return files alongside directories in /api/browse - #546
Open
RonenMars wants to merge 1 commit into
Open
feat(browse): return files alongside directories in /api/browse#546RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
listDirectories filtered readdir to isDirectory, so the browse endpoint never surfaced files and the mobile Explorer could only show folders. Add a sibling listFiles helper and include its result as a `files` array in the /api/browse response, read in parallel with directories. The field is additive, so existing directories-only clients keep working unchanged.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
listDirectoriesfilteredreaddirtoisDirectory, so/api/browsenever surfaced files and the mobile Explorer could only ever show folders.This adds a sibling
listFileshelper and includes its result as afilesarray in the/api/browseresponse, read in parallel withdirectories.Why
The mobile Explorer wants to display files (view-only) so a user can see a folder's contents before starting a session.
Directories alone were not enough context.
Shape
/api/browsenow returns{ path, directories, files }.The
filesfield is additive, so existing directories-only clients keep working unchanged.Tests
__tests__/browse.test.tsgainslistFilescoverage (sorted, excludes directories, empty case) plus an assertion thatlistDirectoriesexcludes files.vitest run __tests__/browse.test.ts— 21/21 pass;tsc --noEmit— 0 errors.