Potential fix for code scanning alert no. 25: Server-side URL redirect - #83
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
MarkProminic
marked this pull request as ready for review
October 1, 2025 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/STARTcloud/armor/security/code-scanning/25
To fix this server-side redirect issue, we should ensure that any user-provided path used in a redirect cannot result in a navigation outside the intended application domain/root. The best way to achieve this here is to use a robust validator, preferably encapsulated in a function (such as
isLocalUrl), to ensure that the redirect is strictly local—i.e., it must remain on the same host and not encode an absolute URL or start with protocol-relative forms.In this specific case in
routes/fileServer.js, before usingsafeRedirectPathas a redirect target (on line 241), we should callisLocalUrl(safeRedirectPath)(the function imported from../config/paths.js). IfisLocalUrlreturns true, perform the redirect; else, refuse (e.g., by responding with an error or redirecting to '/'). This is a minimal change that does not alter existing functionality beyond making the redirect secure.Changes to make:
if (isLocalUrl(safeRedirectPath)) ... else ...isLocalUrlis already imported.Suggested fixes powered by Copilot Autofix. Review carefully before merging.