Skip to content

Potential fix for code scanning alert no. 25: Server-side URL redirect #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkProminic merged 1 commit into from
Oct 1, 2025
Merged

Potential fix for code scanning alert no. 25: Server-side URL redirect #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion routes/fileServer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,12 @@
return res.status(400).send('Invalid redirect path');
}

return res.redirect(301, safeRedirectPath);
if (isLocalUrl(safeRedirectPath)) {
return res.redirect(301, safeRedirectPath);
} else {

Check failure on line 243 in routes/fileServer.js

View workflow job for this annotation

GitHub Actions / Lint & Format 

Unnecessary 'else' after 'return'
logger.warn('Blocked attempted open redirect', { path: safeRedirectPath });
return res.status(400).send('Invalid redirect path');
}
}
return handleDirectoryListing(req, res, fullPath, requestPath);
}
Expand Down
Loading