Added a time-out to active service check to ensure it doesn't loop forever - #460
Open
SheFellFromHeaven wants to merge 2 commits into
Open
Added a time-out to active service check to ensure it doesn't loop forever#460SheFellFromHeaven wants to merge 2 commits into
SheFellFromHeaven wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
Author
|
Workflow failure seems unrelated to anything I've changed |
bakerboy448
added a commit
to bakerboy448/ServarrWiki
that referenced
this pull request
Sep 4, 2026
The post-install loop waited on `systemctl is-active` with no exit, so a service that never starts (for example a missing libicu dependency) looped forever. Add a 15-attempt guard that reports the failure and exits 1. Cherry-picked from community PR Servarr#460.
Contributor
augustuen
pushed a commit
that referenced
this pull request
Sep 5, 2026
The post-install loop waited on `systemctl is-active` with no exit, so a service that never starts (for example a missing libicu dependency) looped forever. Add a 15-attempt guard that reports the failure and exits 1. Cherry-picked from community PR #460.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Used this script today to install Lidarr, but the dependency list was apparently incomplete, since libicu76 is no longer part of Debian as part of the base install, and the installation script didn't catch that. Due to that, the script got all the way to starting the Lidarr service in systemctl, only for it to get stuck there as the dependency was missing and the service couldn't get started.
I added a small counter that makes sure that the loop ends after ~15 seconds, ensuring that if something goes wrong, it doesn't wait forever for a service that will never start. I've tested it and it works. The timeout can be changed, I just thought 15 seconds was good enough.
Example image of what happens when it fails to start properly:
