fix: Windows PowerShell snippet + install-script service-wait timeout - #467
Merged
Conversation
Use a trailing pipe in the tips-and-tricks PowerShell snippet; the leading-pipe continuation is invalid in Windows PowerShell 5.1.
The post-install loop waited on `systemctl is-active` with no exit, so a service that never starts (for example a missing libicu dependency) looped forever. Add a 15-attempt guard that reports the failure and exits 1. Cherry-picked from community PR Servarr#460.
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small, unrelated fixes split out of #466 so the grounding/security work can be reviewed on its own.
tips-and-tricks.md: the Windows PowerShell folder-creation snippet used a leading-pipe continuation, which is invalid in Windows PowerShell 5.1. Switched to a trailing pipe.servarr/servarr-install-script.sh: the post-installsystemctl is-activewait loop had no exit, so a service that never starts (for example a missing libicu dependency) looped forever. Added a 15-attempt timeout that reports the failure and exits. Cherry-picked from Added a time-out to active service check to ensure it doesn't loop forever #460.