Validate submit root is a graph with --skip-validation bypass#27
Draft
arseniy-pplx wants to merge 1 commit into
Draft
Validate submit root is a graph with --skip-validation bypass#27arseniy-pplx wants to merge 1 commit into
arseniy-pplx wants to merge 1 commit into
Conversation
By default, pipeline-runs submit now rejects a bare-container root locally, before any API call, with an actionable message pointing at the graph-root requirement and the bypass flag. The check runs after hydration/resolution against the canonical submit spec (root_task.componentRef.spec), so valid graph pipelines and resolved component references are unaffected. Add --skip-validation (and a matching skip_validation config key, which must be a real boolean) to bypass only this root-shape check and submit the body unchanged; parsing, hydration, and security checks still run.
Volv-G
added a commit
that referenced
this pull request
Jul 15, 2026
Run the full pipelines validate authoring validator during pipeline-runs submit and --dry-run after hydration, and route PipelineRunner through the same base hook. Root graph requirements are enforced by the authoring validator, with README and tests updated. Bump tangle-cli patch version to 0.1.3. This is based on master and intentionally excludes PR #27 skip-validation CLI flag and separate submit-root check. Assisted-By: devx/5490f7cb-c7e4-4cf5-b525-a8c4e2af55b1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tangle sdk pipeline-runs submitbuilds an API submit payload fromroot_task.componentRef.specand, until now, submitted whatever root shape the spec resolved to. A bare-container root (implementation.container) is accepted by the API but cannot run under current orchestrators, which require a graph root (implementation.graph) — the run later fails server-side with no local signal.This change validates the resolved root locally, before any network call, and fails fast with an actionable message when the root is a bare container. An explicit opt-out preserves forward compatibility and advanced testing.
What changed
submit(and--dry-run) now reject a bare-container root before contacting the API, with a message that names the graph-root requirement and the bypass flag.root_task.componentRef.spec), so valid graph pipelines and resolved component references are not falsely rejected. Graph-root behavior is unchanged.implementationmapping, or without a container root, are left for the API to validate.--skip-validation(and a matchingskip_validationconfig key) bypass only this root-shape check and submit the body unchanged. Parsing, hydration, and security checks still run. The config value must be a real boolean; anything else fails with an invalid-config error.prepare_submit_payload_from_spec, which backs both the dry-run and real-submit paths, while leaving the prepared-body escape hatches untouched.Test plan
--skip-validation--skip-validationsubmits the bare body unchanged and reaches the clientskip_validationhonored via config file; non-boolean config value rejecteduv run --frozen pytest -q(pre-existing unrelated failures only),uv build, CLI smoke test🤖 Generated by Computer