Skip to content

Stream Skill installation without default byte caps - #1592

Merged
Open-Squilla merged 7 commits into
mainfrom
fix/skill-streaming-install
Sep 16, 2026
Merged

Open-Squilla merged 7 commits into
mainfrom
fix/skill-streaming-install

Conversation

@Open-Squilla

@Open-Squilla Open-Squilla commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Large Skill packages now stream into managed staging without default byte caps. GitHub workers share download slots and retry transient failures; incremental scanning and hashing keep the Gateway event loop responsive.

Scope

Scope boundary: streaming GitHub and ClawHub downloads, staging workers, scanner boundaries, and regression coverage. Explicit aggregate download limits now apply while chunks arrive, even when upstream sizes are missing or understated. Oversized manifests are rejected before reading, and long-line scanning preserves word boundaries.

Branch

Base branch: main
Target exception: N/A

The source-selection prerequisite #1591 is already merged. This branch includes current main; #1593 and #1594 follow separately.

Issue

Linked issue: None
If None, reason: improve the existing Community Skill installation path and fix its streaming edge cases.

Release Note

Release note: large Community Skills install without the former default byte ceiling while explicit limits and safety checks remain enforced. No version metadata change.

Tests

Ruff: full source and tests passed.
Pytest: updated streaming, scanner, management, and CI-planner regression gate passed (see current CI for platform results).
Build: WebUI build passed on the combined reviewed stack; this PR does not change WebUI sources.
Regression tests: added for unknown/understated aggregate sizes, retry budget accounting, oversized manifests, worker execution, and long identifier boundaries.
Notes: previous PR-head CI results are superseded by the checks on this updated head. Full Linux/Windows shards and the three-platform Skill contract job must be judged from the new CI run. Default tests remain offline, deterministic, credential-free, and fork-safe.

Queue validation also exposed existing compaction fixtures that assumed the former len//4 token fallback. The same five failures reproduced on main with the current conservative UTF-8 estimator. Synthetic inputs now remain within the intended provider budgets, and the affected cases explicitly exercise fallback mode; all original behavioral assertions remain enforced. The complete affected file passed 52 tests. Production compaction budgets are unchanged.

Maintainer Live Check

Maintainer live check: no
Surface: N/A

Safety

Path, link, special-file, compression-ratio, entry-count, and manifest guards remain enforced. Cancellation settles workers before cleanup. Retry truncation releases only that file's byte reservation. Portable paths and existing Windows mode behavior are preserved. No secrets, private transcripts, local artifacts, or machine-specific paths are included.

Third-Party Origin

Third-party origin: none
Original implementation; no third-party code copied.

@Open-Squilla
Open-Squilla force-pushed the fix/skill-streaming-install branch from e44b81b to f56f974 Compare September 9, 2026 12:24
@Open-Squilla
Open-Squilla added this pull request to the merge queue Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: failurerun 35073797936, attempt 1.
Tested queue candidate: 3d1bb65b6e1ab7e6e122e5d7efbdbc45d21c87ce. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: successrun 35073511089, attempt 1.
Tested queue candidate: 74736c1abe0a23b8a3471cd665bd1e413ffc15ad. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

@Open-Squilla
Open-Squilla added this pull request to the merge queue Sep 16, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: successrun 35080696517, attempt 1.
Tested queue candidate: 14087d9cefa56ced625a08cdb5ec76404aa1b295. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

Merged via the queue into main with commit 14087d9 Sep 16, 2026
80 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant