Finish Agent Skill installs from trusted runtime receipts - #1594
Merged
Merged
Conversation
Open-Squilla
force-pushed
the
fix/skill-install-turn-completion
branch
2 times, most recently
from
September 9, 2026 11:57
c5ef48f to
0674d90
Compare
Open-Squilla
force-pushed
the
fix/skill-install-turn-completion
branch
from
September 9, 2026 12:24
0674d90 to
3d32cbc
Compare
Open-Squilla
force-pushed
the
fix/skill-install-turn-completion
branch
from
September 9, 2026 12:58
3d32cbc to
c66b524
Compare
Open-Squilla
enabled auto-merge
September 16, 2026 16:30
|
Merge queue CI: success — run 35134181420, attempt 1. The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An installation-only Agent turn now finishes from trusted built-in runtime receipts after all requested Skills succeed. The Agent keeps working on mixed requests, retains instructions added during installation, and accurately describes installed Skills that are unavailable or degraded.
Scope
Scope boundary: early installation-tool visibility, turn-local receipt reuse, batch completion, pending user input, and pinned-catalog descriptions. New user input allows failed installs to be retried while successful receipts remain reusable. Disabled, shadowed, needs_setup, and degraded results retain their availability explanations.
Branch
Base branch: main
Target exception: N/A
Updated against main after #1592 and #1593 merged.
Issue
Linked issue: None
If None, reason: finish scoped Skill installation turns reliably without losing remaining work or user instructions.
Release Note
Release note: Agent Skill installation ends once all requested installs succeed, preserves mixed-task work and new user instructions, and explains unavailable Skills accurately. Newly installed Skills become visible on the next turn. No version metadata change.
Tests
Ruff: full source and tests passed on the reviewed stack.
Pytest: 390 tests passed after merging current main, covering Agent installation completion, settlement, ToolContext compatibility, CI planning and workflows. Earlier reviewed-stack checks covered 80 installation and mid-turn input regressions.
Build: WebUI build and full-package mypy passed on the reviewed stack.
Regression tests: added for same-batch and sequential installs, partial failure, mixed tasks, input during fetch/result delivery, user-selected directory retries, risk-token validation, unavailable/degraded results, cancellation, and positional compatibility.
Notes: turn logic is platform-neutral. Updated-head CI provides platform acceptance; previous PR-head CI does not validate this update. Default tests remain offline, deterministic, credential-free, and fork-safe. No new live-model validation was performed for this update.
Maintainer Live Check
Maintainer live check: no
Surface: N/A
Safety
Finalization trusts only built-in runtime receipts. Skill document text and model-supplied retry parameters cannot authorize retries or finalization. Existing permission checks, risk approval, cancellation, Plan/goal constraints, and pinned-catalog behavior remain enforced. ToolContext appends the receipt field after existing published fields. No secrets, private transcripts, local artifacts, or machine-specific paths are included.
Third-Party Origin
Third-party origin: none
Original implementation; no third-party code copied.