Skip to content

Split password-instances into multiple packages (#1) - #87

Merged
Vlix merged 10 commits into
cdepillabout:masterfrom
blackheaven:refactor/split-password-instances
Apr 5, 2026
Merged

Split password-instances into multiple packages (#1)#87
Vlix merged 10 commits into
cdepillabout:masterfrom
blackheaven:refactor/split-password-instances

Conversation

@blackheaven

@blackheaven blackheaven commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

It's mostly cut and paste.

@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch 7 times, most recently from 87f6ea3 to 1609803 Compare October 5, 2025 00:39
This was referenced Oct 5, 2025
Merged
Closed
@Vlix

Vlix commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

Did you build with -Wunused-imports and -Wunused-packages?
Just to be sure we're not depending on, or importing unnecessary packages/modules?

Vlix
Vlix requested changes Oct 7, 2025
View reviewed changes

@Vlix Vlix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad. Seems like what we were looking for.

Comment thread password-aeson/src/Data/Password/Aeson.hs Outdated
Comment thread password-aeson/src/Data/Password/Aeson.hs Outdated
Comment thread password-aeson/password-aeson.cabal Outdated
Comment thread password-aeson/password-aeson.cabal Outdated
Comment thread password-instances/src/Data/Password/Instances.hs
Comment thread password-persistent/test/tasty/Spec.hs Outdated
@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch from 1609803 to 66379d8 Compare October 7, 2025 18:58
@blackheaven

blackheaven commented Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

Did you build with -Wunused-imports and -Wunused-packages? Just to be sure we're not depending on, or importing unnecessary packages/modules?

yes :)

Vlix
Vlix requested changes Oct 7, 2025
View reviewed changes
Comment thread password-aeson/src/Data/Password/Aeson.hs Outdated
Comment thread password-aeson/src/Data/Password/Aeson.hs Outdated
Comment thread password-instances/password-instances.cabal
Comment thread password-http-api-data/src/Data/Password/HttpApiData.hs Outdated
@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch 6 times, most recently from 1ed4038 to e928900 Compare October 7, 2025 20:49
@blackheaven
blackheaven requested a review from Vlix October 8, 2025 20:43
Vlix
Vlix reviewed Oct 10, 2025
View reviewed changes
Comment thread password-http-api-data/src/Data/Password/HttpApiData.hs Outdated
@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch 3 times, most recently from d6332e6 to 10dd5f5 Compare October 11, 2025 21:13
@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch 2 times, most recently from f40f2dd to aea7f48 Compare October 11, 2025 21:29
@blackheaven
blackheaven force-pushed the refactor/split-password-instances branch from aea7f48 to d2277fe Compare October 12, 2025 14:12
Vlix
Vlix approved these changes Oct 12, 2025
View reviewed changes

@Vlix Vlix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR 🙏 as always.

I'll wait on merging this and make an issue about all the steps for releasing this + the password-cli, plus the next PR; so me or cdepillabout can pick this up when we have time.

@Vlix Vlix mentioned this pull request Oct 12, 2025
Closed
22 tasks
@Vlix

Vlix commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

I've made a PR to @blackheaven 's branch (blackheaven#1) which should resolve the conflicts and also adjusts a few things.

(i.e. remove unused imports/dependencies and change a few unit tests to property tests)

@blackheaven

blackheaven commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

I've made a PR to @blackheaven 's branch (blackheaven#1) which should resolve the conflicts and also adjusts a few things.

(i.e. remove unused imports/dependencies and change a few unit tests to property tests)

Thanks

@Vlix
Vlix merged commit 1f19a77 into cdepillabout:master Apr 5, 2026
0 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout left review comments
@Vlix Vlix Vlix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blackheaven @Vlix @cdepillabout