ossia: reuse value conversion storage - #202
Merged
Merged
Conversation
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The OSSIA conversion boundary builds temporary standard strings and containers even when the destination already owns compatible storage. Allocator-aware strings are also classified as vectors in some overload sets, and allocator-aware string-key maps are encoded as pair lists instead of OSSIA maps.
Changes
ossia::ossiais availableVerification
Built and ran
tests/test_ossia_values.cppdirectly against the score/libossia build configuration:std::variantandboost::variant2active-alternative reuseAlso rebuilt
score_addon_jk, which exercises these conversions with allocator-aware jq values.