fix(workflows): pass --timeout to golangci-lint to fix exit code 4#68
Open
onuryilmaz wants to merge 3 commits into
Open
fix(workflows): pass --timeout to golangci-lint to fix exit code 4#68onuryilmaz wants to merge 3 commits into
onuryilmaz wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the shared Go lint reusable workflow to reduce golangci-lint “timeout exceeded” failures (exit code 4) by wiring a caller-provided timeout into both the job timeout and golangci-lint’s --timeout flag.
Changes:
- Adds a
timeoutworkflow input (minutes) and documents it as applying to both golangci-lint and the job. - Sets
timeout-minuteson the lint job based on the input. - Passes
--timeout=<N>mtogolangci-lintvia the actionargs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
onuryilmaz
force-pushed
the
feat/shared-go-lint-timeout
branch
from
8a593dd to
7c2b58b
Compare
Adds a timeout input (default: 10m) passed as --timeout=<N>m to golangci-lint via the action's args field, fixing the "Timeout exceeded" error. No job-level timeout is set. Signed-off-by: I313226 <onur.yilmaz@sap.com>
onuryilmaz
force-pushed
the
feat/shared-go-lint-timeout
branch
from
45acf81 to
5b40081
Compare
… lint Signed-off-by: I313226 <onur.yilmaz@sap.com>
Signed-off-by: I313226 <onur.yilmaz@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Timeout exceeded: try increasing it by passing --timeout optionerror (exit code 4) from golangci-lint.Adds a
timeoutinput (default:10minutes) passed as--timeout=<N>mdirectly to golangci-lint via the action'sargsfield.Test plan