Skip to content

fix(workflows): pass --timeout to golangci-lint to fix exit code 4 #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onuryilmaz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(workflows): pass --timeout to golangci-lint to fix exit code 4 #68

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b40081
fix(workflows): pass --timeout to golangci-lint to prevent exit code 4
onuryilmaz Jul 6, 2026
02f6d11
fix(workflows): validate timeout is a positive integer before running…
onuryilmaz Jul 6, 2026
d9dbe19
fix(workflows): add shell: bash to validate inputs step
onuryilmaz Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/shared-go-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
default: "latest"
type: string
timeout:
description: "Timeout in minutes for the lint job"
description: "Timeout in minutes passed to golangci-lint via --timeout"
Comment thread
onuryilmaz marked this conversation as resolved.
required: false
default: 10
type: number
Expand All @@ -37,13 +37,22 @@ on:
jobs:
lint:
runs-on: ${{ inputs.runs-on }}
timeout-minutes: ${{ inputs.timeout }}
permissions:
Comment thread
onuryilmaz marked this conversation as resolved.
contents: read
defaults:
run:
working-directory: ${{ inputs.working-directory }}
steps:
- name: Validate inputs
shell: bash
env:
TIMEOUT: ${{ inputs.timeout }}
run: |
Comment thread
onuryilmaz marked this conversation as resolved.
if ! echo "$TIMEOUT" | grep -qE '^[1-9][0-9]*$'; then
echo "ERROR: timeout must be a positive integer (got: '$TIMEOUT')"
exit 1
fi

- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

Expand All @@ -59,6 +68,7 @@ jobs:
with:
version: ${{ inputs.golangci-lint-version }}
working-directory: ${{ inputs.working-directory }}
args: --timeout=${{ inputs.timeout }}m

- name: Run govulncheck
if: inputs.enable-govulncheck == true
Expand Down