fix(file-explorer): Prevent TypeError when branch contents include null rows - #4108
sentry[bot] wants to merge 1 commit into
Conversation
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4108 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15148 +1
Branches 4387 4387
=======================================
+ Hits 14961 14962 +1
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #4108 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15148 +1
Branches 4379 4379
=======================================
+ Hits 14961 14962 +1
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15148 +1
Branches 4387 4379 -8
=======================================
+ Hits 14961 14962 +1
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4108 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 823 823
Lines 15147 15148 +1
Branches 4387 4387
=======================================
+ Hits 14961 14962 +1
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Description
This PR addresses a
TypeError: null is not an object (evaluating 'h[o.accessorKey]')that occurred in the file explorer table.The root cause was identified as
nullentries being present in therawTableRowsarray, which is then passed to TanStack Table. Thesenullentries originated from theuseRepoBranchContentsAPI response, where some path content results could benull.The fix involves filtering out these
nullentries from therawTableRowsarray before it is used to construct the table data. This ensures that TanStack Table only receives valid row objects, preventing theTypeErrorwhen attempting to access properties on anullobject.Code Example
N/A
Notable Changes
Filtered out
nullentries from therawTableRowsarray before passing it to TanStack Table to preventTypeError.Screenshots
N/A
Link to Sample Entry
N/A
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-186J
This PR was automatically generated by Sentry. You can adjust this setting at any time.