Skip to content

fix(file-explorer): Prevent TypeError when branch contents include null rows #4108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(file-explorer): Prevent TypeError when branch contents include null rows #4108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...poPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
return adjustListIfUpDir({
treePaths,
displayType: selectedDisplayType,
rawTableRows: rawTableRows as Row[],
rawTableRows: rawTableRows.filter((row): row is Row => row !== null),

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Helmtest 

A type predicate's type must be assignable to its parameter's type.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Helmtest 

Type '({ name: Element | undefined; lines: string; hits: string; partials: string; misses: string; coverage: Element; } | null)[]' is not assignable to type 'Row[]'.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Run Type Checker 

A type predicate's type must be assignable to its parameter's type.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Run Type Checker 

Type '({ name: Element | undefined; lines: string; hits: string; partials: string; misses: string; coverage: Element; } | null)[]' is not assignable to type 'Row[]'.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Production 

A type predicate's type must be assignable to its parameter's type.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Production 

Type '({ name: Element | undefined; lines: string; hits: string; partials: string; misses: string; coverage: Element; } | null)[]' is not assignable to type 'Row[]'.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Staging 

A type predicate's type must be assignable to its parameter's type.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Upload Bundle Stats - Staging 

Type '({ name: Element | undefined; lines: string; hits: string; partials: string; misses: string; coverage: Element; } | null)[]' is not assignable to type 'Row[]'.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Build App 

A type predicate's type must be assignable to its parameter's type.

Check failure on line 185 in src/pages/RepoPage/CoverageTab/OverviewTab/subroute/FileExplorer/hooks/useRepoBranchContentsTable.tsx

View workflow job for this annotation

GitHub Actions / Build App 

Type '({ name: Element | undefined; lines: string; hits: string; partials: string; misses: string; coverage: Element; } | null)[]' is not assignable to type 'Row[]'.
})
}, [branchData?.pages, branch, treePaths, urlPath, selectedDisplayType])

Expand Down
Loading