refactor(web)!: drop the schedule trigger and cron column (CL-8527) - #918
Merged
Merged
Conversation
Interchange's `schedule` workflow trigger is reserved but unimplemented — no scheduler fires it — so stop offering it: Myra's package contract, the chat deploy card, and agent-deploy.ts drop the schedule input and trigger, and the Workflows page/detail page drop the dead cron column and sentence (routines-api.ts already only ever reported "manual").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduleworkflow trigger is reserved but unimplemented (no scheduler fires it), so Workbench stops offering it.agent-deploy.tsdrop thescheduleinput and the{ type: "schedule", cron }trigger — only the mail trigger remains.routines-api.tscould only ever report as"manual"anyway.packages/cronis untouched: it's still mounted inapps/hub's Corbits block as a cron-to-mail bridge, unrelated to this dead trigger type.Test plan
bun run check