Skip to content

Clarify replica quorum write error message#7704

Open
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:clarify-replica-write-error-message
Open

Clarify replica quorum write error message#7704
Rohithmatham12 wants to merge 1 commit into
cortexproject:masterfrom
Rohithmatham12:clarify-replica-write-error-message

Conversation

@Rohithmatham12

Copy link
Copy Markdown

What this changes

  • Rewords the write quorum error emitted from pkg/ring/batch.go when enough replicas return the same error family.
  • Keeps the same wrapping behavior and address/state/zone context.
  • Updates the nearby comment to describe the condition in operator-facing terms instead of the internal maxFailure variable name.

Fixes #5732.

Testing

  • GOCACHE=/private/tmp/cortex-go-cache GOMODCACHE=/private/tmp/cortex-go-mod-cache go test ./pkg/ring
  • git diff --check

Signed-off-by: Rohithmatham12 <rohithmatham@gmail.com>
@dosubot dosubot Bot added component/ring type/chore Something that needs to be done; not a bug or a feature labels Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ring size/XS type/chore Something that needs to be done; not a bug or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"maxFailure (quorum) on a given error family" error: consider different wording

1 participant