Skip to content

Clarify replica quorum write error message #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohithmatham12 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Clarify replica quorum write error message #7704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/ring/batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,16 @@ func (b *batchTracker) record(instance instance, err error) {
// Track the number of errors by error family, and if it exceeds maxFailures
// shortcut the waiting rpc.
errCount := instance.itemTrackers[i].recordError(err)
// We should return an error if we reach the maxFailure (quorum) on a given error family OR
// we dont have any remaining ingesters to try
// We should return an error if enough replicas have returned the same error
// family to make quorum impossible, or if we don't have any remaining ingesters to try.
// Ex: 2xx, 4xx, 5xx -> return 4xx
// Ex: 2xx, 5xx, 4xx -> return 4xx
// Ex: 4xx, 4xx, _ -> return 4xx
// Ex: 5xx, _, 5xx -> return 5xx
if errCount > int32(sampleTrackers[i].maxFailures) {
if b.rpcsFailed.Inc() == 1 {
b.err <- httpgrpcutil.WrapHTTPGrpcError(
sampleTrackers[i].getError(), "maxFailure (quorum) on a given error family, addr=%s state=%s zone=%s",
sampleTrackers[i].getError(), "write failed because replicas reached quorum on the same error family, addr=%s state=%s zone=%s",
instance.desc.Addr, instance.desc.State, instance.desc.Zone)
}
continue
Expand Down