Update dcf-card-as-link.js - #620
Open
cmdprompt wants to merge 3 commits into
Open
Conversation
removed id code, there were no methods in here that used/required ids be present on the card or link elements. there is no reason to require it. a clickable container with nested links is semantically confusing, should be only one link. included branch such that the decorator `.dcf-card-link` is not necessary ( but still supported if its present )
Member
|
Card-as-link user interface based on cards described in Inclusive Components article. The author cites the example of author links as a potential use case for secondary links. In most cases a secondary link is not needed, but we've built in the option nonetheless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed id code, there were no methods in here that used/required ids be present on the card or link elements. there is no reason to require it.
a clickable container with nested links is semantically confusing, should be only one link. included branch such that the decorator
.dcf-card-linkis not necessary ( but still supported if its present )