Skip to content

Update dcf-card-as-link.js #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmdprompt wants to merge 3 commits into
base: 4.1
Choose a base branch
from
Open

Update dcf-card-as-link.js #620

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9e73c7
Update dcf-card-as-link.js
cmdprompt Aug 21, 2026
5f57f7c
Update dcf-card-as-link.js
cmdprompt Aug 21, 2026
1ecb8c2
Update dcf-card-as-link.js
cmdprompt Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions js/components/dcf-card-as-link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
import { uuidv4 } from '../dcf-utility.js';

// Based on https://inclusive-components.design/cards/
// Using mousedown and mouseup to allow selecting text without trigger click
export default class DCFCardAsLink {
uuid = uuidv4();

card = null;

link = null;
Expand All @@ -20,14 +16,8 @@ export default class DCFCardAsLink {
// Set up the Card as Link component
constructor(card) {
this.card = card;
if (this.card.getAttribute('id') === '' || this.card.getAttribute('id') === null) {
this.card.setAttribute('id', this.uuid.concat('-card-as-link'));
}

this.link = card.querySelector('.dcf-card-link');
if (this.link.getAttribute('id') === '' || this.link.getAttribute('id') === null) {
this.link.setAttribute('id', this.uuid.concat('-card-as-link-link'));
}
this.link = card.querySelector('.dcf-card-link') || card.querySelector('a');

// Add event listeners only if a link is present in the card
if (this.link) {
Expand Down