Bound resource deletion in tests and drop fixed auto-build delay - #1649
Merged
Merged
Conversation
The force-delete helpers of AbstractJavaProjectTest looped forever when a resource could not be deleted, and tearDown wrapped them in up to 5000 more retries, so a locked file hung the build until the CI job timeout. The helpers now fail after 30 seconds with an error naming the resource, and the redundant outer retry is removed. waitForAutoBuild() also no longer sleeps 25 ms before joining the auto-build job. Assisted-by: multiple AI agents and layers of automated tooling 🤖
ptziegler
approved these changes
Sep 29, 2026
ptziegler
left a comment
ptziegler
left a comment
Contributor
There was a problem hiding this comment.
I don't think I've ever seen the CI builds get stuck due to file removal. But producing a meaningful error is definitely a good idea!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The force-delete helpers in AbstractJavaProjectTest retried forever when a resource could not be deleted, and tearDown wrapped them in up to 5000 more retries, so a single locked file could hang the test run until the CI job timeout. They now fail after 30 seconds with an error naming the resource, which turns a silent hang into a diagnosable test failure. The fixed 25 ms sleep in waitForAutoBuild() is also removed, since the auto-build job is joined right afterwards anyway. The full test suite passed twice locally with the change.