fix: clean up build warnings and sync Colorado Tab5 package - #314
Merged
Conversation
- ble_elm327, divoom: replace deprecated ESPBTUUID::to_string() with to_str() (removed in ESPHome 2026.8.0); fix %u format vs uint32_t argument mismatch; add braces around log-macro-only if bodies that GCC flags as empty when the macro compiles away - divoom: add a default case to the GATT event switch instead of enumerating dozens of irrelevant esp_gattc_cb_event_t values, and scope the WRITE_CHAR_EVT case body so the added case doesn't jump over a variable initialization - uartex: add missing LOCK_STATE_OPEN/OPENING and several MediaPlayerCommand switch cases; fix a duplicated self-assignment (pref_ = pref_ = ...) in uartex_select; brace an empty if body Verified by compiling every affected component's test config against ESPHome 2026.7.4 (esp32-idf) with zero warnings remaining in our code. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Bring the shared package in line with the maintainer's current device config: GPS module (position, speed, altitude, satellites) feeding a ws_bridge device tracker and GNSS BMP280 temperature/pressure, a battery state-of-charge sensor/gauge, refined alert thresholds, and removal of the torque gauge card. Also declares safe_mode (the existing Restart Safemode switch required it, which esphome config now catches) and drops the OTA packages include, since the generated ota_server/devices/esp-colorado-tab5.yaml file is local to the maintainer's Home Assistant install and isn't part of this repo. Also fixes the ESPHome build warnings from this package: - merge_warnings: false for the intentional YAML-anchor overrides (gauge_bar's max_value, gauge_value's x, info_value's text_color) - widen the gear-position snprintf buffer (was undersized for the full int range) - car-lifted-pickup/car-back icons switched from grayscale to binary, matching how every other recolored icon in this package is typed Verified with `esphome config` against ESPHome 2026.7.4. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esp-colorado-tab5-install.txt,esp-kocom-install.txt), plus a handful more surfaced by compiling every component's test config against ESPHome 2026.7.4.ble_elm327,divoom: deprecatedESPBTUUID::to_string()→to_str(),%u/uint32_tformat mismatch, empty-if-body warnings, missingdefault:in a GATT event switch (with a case properly braced instead of enumerating ~40 irrelevant enum values).uartex: missingLOCK_STATE_OPEN/OPENINGandMediaPlayerCommandswitch cases, an empty-if-body warning, and a real bug — a duplicated self-assignment (pref_ = pref_ = ...) inuartex_select.packages/display/colorado/colorado-tab5.yaml: synced to the maintainer's current device config (GPS, battery SOC sensor, refined alert thresholds, torque card removed),merge_warnings: falsefor the intentional YAML-anchor overrides, widened an undersizedsnprintfbuffer, andgrayscale→binaryfor two icons. Also restoressafe_mode:, whichesphome configrequires for the existingRestart Safemodeswitch — a validation error that a bareesphome compiledoesn't surface (it stopped at the C++ warnings first).Test plan
esphome compileforble_elm327,divoom,uartex(esp32-idf) — zero warnings in our code,Successfully compiled program.esphome compileforaxp192,bbq10_keyboard,bmi270,bmm150,ip5306,jaalee_jht,lilygo_t_keyboard,m5unit_scales,sip_client,tca8418_keyboard,tcp_server,ws_bridge— all clean (only pre-existing ESPHome-core warnings we don't control, e.g.crash_handler.cpp).esphome configfor the Colorado Tab5 package against a synthetic device config with the realgithub://eigger/espcomponentsexternal components —Configuration is valid!🤖 Generated with Claude Code