SED-4744 Iteration count incorrect - #1447
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the text-based warning alert in the aggregated tree node iteration list with a standalone warning icon and tooltip, updating the corresponding SCSS styles. Feedback points out that this change reduces accessibility for screen readers and keyboard-only users, and suggests adding an aria-label and tabindex="0" to the icon to restore accessibility.
| <step-icon | ||
| name="alert-triangle" | ||
| class="warning-explanation" | ||
| matTooltip="The count here is exact, based on raw data, while in the tree, the time-series aggregation groups and adjusts counts according to the time resolution." | ||
| matTooltipPosition="below" | ||
| /> |
There was a problem hiding this comment.
Replacing the text-based <step-alert> with a standalone <step-icon> and tooltip makes this warning inaccessible to screen readers and keyboard-only users. To ensure accessibility, add an aria-label describing the warning and a tabindex="0" so keyboard users can focus the icon to trigger the tooltip.
<step-icon
name="alert-triangle"
class="warning-explanation"
matTooltip="The count here is exact, based on raw data, while in the tree, the time-series aggregation groups and adjusts counts according to the time resolution."
matTooltipPosition="below"
tabindex="0"
aria-label="Warning: The number of shown iterations doesn't match the iteration count of the tree"
/>
2 participants
No description provided.