Skip to content

SED-4744 Iteration count incorrect #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neogucky merged 2 commits into from
Sep 17, 2026
Merged

SED-4744 Iteration count incorrect #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf9102
SED-4744 Iteration count incorrect
dvladir Sep 3, 2026
669abff
Merge branch 'master' into SED-4744-iteration-count-incorrect
neogucky Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ...ts/aggregated-tree-node-iteration-list/aggregated-tree-node-iteration-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,12 @@
Only the first 1000 iterations are show
</step-alert>
} @else if (showCountWarning()) {
<step-alert [type]="AlertType.WARNING">
<step-icon name="alert-triangle" />
The number of shown iterations doesn't match the iteration count of the tree
<step-icon
name="help-circle"
class="warning-explanation"
matTooltip="The count here is exact, based on raw data, while in the tree, the time-series aggregation groups and adjusts counts according to the time resolution."
matTooltipPosition="below"
/>
</step-alert>
<step-icon
name="alert-triangle"
class="warning-explanation"
matTooltip="The count here is exact, based on raw data, while in the tree, the time-series aggregation groups and adjusts counts according to the time resolution."
matTooltipPosition="below"
/>
Comment on lines +85 to +90

@gemini-code-assist gemini-code-assist Bot Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Replacing the text-based <step-alert> with a standalone <step-icon> and tooltip makes this warning inaccessible to screen readers and keyboard-only users. To ensure accessibility, add an aria-label describing the warning and a tabindex="0" so keyboard users can focus the icon to trigger the tooltip.

        <step-icon
          name="alert-triangle"
          class="warning-explanation"
          matTooltip="The count here is exact, based on raw data, while in the tree, the time-series aggregation groups and adjusts counts according to the time resolution."
          matTooltipPosition="below"
          tabindex="0"
          aria-label="Warning: The number of shown iterations doesn't match the iteration count of the tree"
        />

}
</ng-container>
</step-table>
Expand Down
8 changes: 2 additions & 6 deletions ...ts/aggregated-tree-node-iteration-list/aggregated-tree-node-iteration-list.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,7 @@ step-aggregated-tree-node-iteration-list {
}
}

step-alert {
margin-bottom: 0;
padding: 0.5rem;
.warning-explanation {
margin-left: 0.5rem;
}
.warning-explanation {
color: var.$orange;
}
}