fix(cli): log UID resolution failures in sentry cli fix - #1541
Merged
Merged
Conversation
…lently returning null
The resolveUid function catches execFileSync failures silently, returning
null without any diagnostic output. When `sudo sentry cli fix` cannot
determine the real user's UID, it bails early with a generic message
("Could not determine a non-root UID") but never logs the underlying
system error (e.g., unknown username, missing `id` binary, permission denied).
Add log.debug() to surface the username and error, and remove the
grandfathered biome-ignore suppression.
Co-authored-by: Miguel Betegón <miguelbetegongarcia@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Sep 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix silent catch in
resolveUid()insrc/commands/cli/fix.ts.Root cause
The
resolveUidfunction catchesexecFileSync("id", ["-u", ...])failures silently, returningnullwithout any diagnostic output. Whensudo sentry cli fixcannot determine the real user's UID (e.g.,SUDO_USERis set to an unknown username, or theidbinary is missing), the command bails early with a generic "Could not determine a non-root UID" message but never logs the underlying system error.Reproduction
sudo sentry cli fixwithSUDO_USERset to a username that doesn't exist on the systemid -ucallFix
log.debug()to surface the username and theexecFileSyncerrorbiome-ignore lint/pluginsuppression commentnullas a fallback, but the error is now visible in debug logs (--log-level debug)