Skip to content

fix(cli): log UID resolution failures in sentry cli fix #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Sep 8, 2026
Merged

fix(cli): log UID resolution failures in sentry cli fix #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/cli/src/commands/cli/fix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
import { OutputError } from "../../lib/errors.js";
import { formatFixResult } from "../../lib/formatters/human.js";
import { CommandOutput } from "../../lib/formatters/output.js";
import { logger } from "../../lib/logger.js";
import { getRealUsername } from "../../lib/utils.js";

type FixFlags = {
Expand Down Expand Up @@ -251,16 +252,18 @@ async function checkOwnership(
* Uses `execFileSync` (not `execSync`) so the username is passed as a
* separate argument — the shell never interpolates it, preventing injection.
*/
const log = logger.withTag("cli.fix");

function resolveUid(username: string): number | null {
// biome-ignore lint/plugin: grandfathered silent catch — see #1531; drain by adding log.debug()/log.warn() or re-throwing.
try {
const result = execFileSync("id", ["-u", "--", username], {
encoding: "utf-8",
stdio: ["pipe", "pipe", "ignore"],
});
const uid = Number(result.trim());
return Number.isNaN(uid) ? null : uid;
} catch {
} catch (error) {
log.debug(`Failed to resolve UID for user "${username}"`, error);
return null;
}
}
Expand Down
Loading