Add passing and failing tests for IncludeGuardsNotUsed exclusion check feedback

[Copilot]

Description

Addresses review feedback on #1194 (#1194 (comment)) by adding a passing and a failing test that exercise the not isExcluded(file, getQuery()) check added to the shared IncludeGuardsNotUsed query.

For both the C and C++ variants of the shared query test:

• Added a header with a missing include guard that is not excluded (headers/test7.hpp / headers/test8.h), which still alerts (failing/NON_COMPLIANT case).
• Added an equivalent header under headers/excluded/ (headers/excluded/test7.hpp / headers/excluded/test8.h), together with a coding-standards.yml (and generated coding-standards.xml) deviation record targeting the test harness's TestQuery rule id, so its alert is suppressed via isExcluded (passing/COMPLIANT case).
• Updated the corresponding .expected files.

Verified locally with codeql test run that both tests pass, and that temporarily reverting the not isExcluded(...) check causes both new tests to fail, confirming they correctly exercise the exclusion behavior.

Original PR: #1194

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • rule number here
• Queries have been modified for the following rules:
  • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No (only test fixtures were added/modified; no production query logic changed)

🚨

[Copilot]

🟡 Changes recommended

One changed C++ test line exceeds the mandatory 100-character limit.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds C and C++ regression coverage for IncludeGuardsNotUsed exclusion handling.

Changes:

• Adds excluded and non-excluded header fixtures.
• Adds deviation configurations using the test rule ID.
• Updates expected alerts. No change note is required for test-only changes.

File summaries

File	Description
cpp/common/test/rules/includeguardsnotused/test.cpp	Includes new C++ fixtures.
cpp/common/test/rules/includeguardsnotused/IncludeGuardsNotUsed.expected	Adds the non-excluded C++ alert.
cpp/common/test/rules/includeguardsnotused/headers/test7.hpp	Adds the failing C++ fixture.
cpp/common/test/rules/includeguardsnotused/headers/excluded/test7.hpp	Adds the excluded C++ fixture.
cpp/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.yml	Configures the C++ deviation.
cpp/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.xml	Adds generated C++ deviation data.
c/common/test/rules/includeguardsnotused/test.c	Includes new C fixtures.
c/common/test/rules/includeguardsnotused/IncludeGuardsNotUsed.expected	Adds the non-excluded C alert.
c/common/test/rules/includeguardsnotused/headers/test8.h	Adds the failing C fixture.
c/common/test/rules/includeguardsnotused/headers/excluded/test8.h	Adds the excluded C fixture.
c/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.yml	Configures the C deviation.
c/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.xml	Adds generated C deviation data.

Review details

• Files reviewed: 12/12 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.