Skip to content

Add passing and failing tests for IncludeGuardsNotUsed exclusion check feedback #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaluda merged 3 commits into from
Sep 4, 2026
Merged

Add passing and failing tests for IncludeGuardsNotUsed exclusion check feedback #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a857eb8
Initial plan
Copilot Sep 4, 2026
6fb9703
Add passing/failing tests for IncludeGuardsNotUsed exclusion behavior
Copilot Sep 4, 2026
35c8882
Update include guard compliance comments in test.cpp
mbaluda Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions c/common/test/rules/includeguardsnotused/IncludeGuardsNotUsed.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
| headers/test4.h:0:0:0:0 | headers/test4.h | Header file test4.h is missing expected include guard. | headers/test4.h:0:0:0:0 | headers/test4.h | |
| headers/test5.h:0:0:0:0 | headers/test5.h | Header file test5.h is missing expected include guard. | headers/test5.h:0:0:0:0 | headers/test5.h | |
| headers/test7.h:0:0:0:0 | headers/test7.h | Header file test7.h is never included by reusing the include guard used by $@. | headers/test6.h:0:0:0:0 | headers/test6.h | include guard |
| headers/test8.h:0:0:0:0 | headers/test8.h | Header file test8.h is missing expected include guard. | headers/test8.h:0:0:0:0 | headers/test8.h | |
10 changes: 10 additions & 0 deletions c/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" ?>
<codingstandards>
<!--GENERATED: DO NOT MODIFY. Changes should be made to coding-standards.yml instead.-->
<deviations>
<deviations-entry>
<rule-id>cpp-test-dummy</rule-id>
<justification>This header is deliberately excluded to test the exclusion mechanism.</justification>
</deviations-entry>
</deviations>
</codingstandards>
3 changes: 3 additions & 0 deletions c/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
deviations:
- rule-id: cpp-test-dummy
justification: This header is deliberately excluded to test the exclusion mechanism.
2 changes: 2 additions & 0 deletions c/common/test/rules/includeguardsnotused/headers/excluded/test8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// COMPLIANT - excluded via deviation
int g7;
2 changes: 2 additions & 0 deletions c/common/test/rules/includeguardsnotused/headers/test8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// NON_COMPLIANT
int g6;
6 changes: 5 additions & 1 deletion c/common/test/rules/includeguardsnotused/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,8 @@

#include "headers/test6.h" //NON_COMPLIANT - non unique and reported in alert for the next

#include "headers/test7.h" //NON_COMPLIANT - non unique
#include "headers/test7.h" //NON_COMPLIANT - non unique

#include "headers/test8.h" //NON_COMPLIANT - missing include guard, not excluded

#include "headers/excluded/test8.h" //COMPLIANT - missing include guard, but excluded via deviation
1 change: 1 addition & 0 deletions cpp/common/test/rules/includeguardsnotused/IncludeGuardsNotUsed.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
| headers/test4.hpp:0:0:0:0 | headers/test4.hpp | Header file test4.hpp is missing expected include guard. | headers/test4.hpp:0:0:0:0 | headers/test4.hpp | |
| headers/test5.hpp:0:0:0:0 | headers/test5.hpp | Header file test5.hpp is missing expected include guard. | headers/test5.hpp:0:0:0:0 | headers/test5.hpp | |
| headers/test6.hpp:0:0:0:0 | headers/test6.hpp | Header file test6.hpp is missing expected include guard. | headers/test6.hpp:0:0:0:0 | headers/test6.hpp | |
| headers/test7.hpp:0:0:0:0 | headers/test7.hpp | Header file test7.hpp is missing expected include guard. | headers/test7.hpp:0:0:0:0 | headers/test7.hpp | |
10 changes: 10 additions & 0 deletions cpp/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" ?>
<codingstandards>
<!--GENERATED: DO NOT MODIFY. Changes should be made to coding-standards.yml instead.-->
<deviations>
<deviations-entry>
<rule-id>cpp-test-dummy</rule-id>
<justification>This header is deliberately excluded to test the exclusion mechanism.</justification>
</deviations-entry>
</deviations>
</codingstandards>
3 changes: 3 additions & 0 deletions cpp/common/test/rules/includeguardsnotused/headers/excluded/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
deviations:
- rule-id: cpp-test-dummy
justification: This header is deliberately excluded to test the exclusion mechanism.
2 changes: 2 additions & 0 deletions cpp/common/test/rules/includeguardsnotused/headers/excluded/test7.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// COMPLIANT - excluded via deviation
int g7;
2 changes: 2 additions & 0 deletions cpp/common/test/rules/includeguardsnotused/headers/test7.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// NON_COMPLIANT
int g6;
6 changes: 5 additions & 1 deletion cpp/common/test/rules/includeguardsnotused/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@

#include "headers/test5.hpp" //COMPLIANT - non unique precedes malformed

#include "headers/test6.hpp" //COMPLIANT - non unique
#include "headers/test6.hpp" //COMPLIANT - non unique

#include "headers/test7.hpp" //NON_COMPLIANT - missing include guard, not excluded

#include "headers/excluded/test7.hpp" // COMPLIANT - excluded via deviation
Loading