fix(traits): hand a trait its saved state back on load - #5590
Merged
collindutter merged 0 commit intoSep 22, 2026
Merged
collindutter merged 0 commit into
collindutter merged 0 commit into
Conversation
collindutter
added this pull request to stack #5592
September 18, 2026 22:23
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
| from griptape_nodes.traits.slider import Slider | ||
|
|
||
|
|
||
| class Twin(Trait): |
| _ALLOWED_LEVEL = 2 | ||
|
|
||
|
|
||
| class Ranged(Trait): |
collindutter
force-pushed
the
fix/trait-state-reaches-the-trait
branch
from
September 22, 2026 22:55
c057bb1 to
418a9a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A save restored trait-rendered
ui_optionsbut left the live trait at its constructor defaults, so the editor could showmax_val=50whileSliderstill accepted80. Stateful traits now expose plain save/load hooks, and the engine applies state to the instance built by node code so callbacks and other wiring remain intact:Closes #5440. Refs #5442.
📚 Documentation preview 📚: https://griptape-nodes--5590.org.readthedocs.build/en/5590/