Added the hashlist isSecret field to the taskdisplayview - #2480
Open
jessevz wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new hashlistIsSecret feature metadata is inconsistent with other hashlist-derived fields (read_only/protected), which can lead to misleading API/model capability definitions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds the Hashlist.isSecret flag into the TaskWrapperDisplay view and corresponding PHP model so the UI API can surface whether a task’s hashlist is marked secret.
Changes:
- Updated
TaskWrapperDisplaySQL view (Postgres + MySQL) to includeh.isSecret AS hashlistIsSecret. - Extended
TaskWrapperDisplayPHP model + factory to carry/serialize the newhashlistIsSecretfield. - Updated the DBA model generator config to include the new field.
File summaries
| File | Description |
|---|---|
| src/migrations/postgres/20260908100000_task-view-add-hashlist-secret-field.sql | Adds hashlistIsSecret column to the Postgres TaskWrapperDisplay view. |
| src/migrations/mysql/20260908100000_task-view-add-hashlist-secret-field.sql | Adds hashlistIsSecret column to the MySQL TaskWrapperDisplay view. |
| src/dba/models/TaskWrapperDisplayFactory.php | Maps the new view column into the TaskWrapperDisplay constructor. |
| src/dba/models/TaskWrapperDisplay.php | Adds the new property, constructor parameter, serialization, and accessor methods. |
| src/dba/models/generator.php | Adds hashlistIsSecret to the generator column list for TaskWrapperDisplay. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jessevz
marked this pull request as draft
September 8, 2026 17:31
jessevz
marked this pull request as ready for review
September 10, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the issecret field from the hashlist to the taskdisplayview so that the frontend can render that it is a secret hashlist