Skip to content

Added the hashlist isSecret field to the taskdisplayview - #2480

Open
jessevz wants to merge 4 commits into
masterfrom
2462-bug-hashlist-secret-unclear
Open

Added the hashlist isSecret field to the taskdisplayview#2480
jessevz wants to merge 4 commits into
masterfrom
2462-bug-hashlist-secret-unclear

Conversation

@jessevz

@jessevz jessevz commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Added the issecret field from the hashlist to the taskdisplayview so that the frontend can render that it is a secret hashlist

@jessevz
jessevz requested review from s3inlc and a lite review from Copilot September 8, 2026 17:23
@jessevz jessevz linked an issue Sep 8, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new hashlistIsSecret feature metadata is inconsistent with other hashlist-derived fields (read_only/protected), which can lead to misleading API/model capability definitions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds the Hashlist.isSecret flag into the TaskWrapperDisplay view and corresponding PHP model so the UI API can surface whether a task’s hashlist is marked secret.

Changes:

  • Updated TaskWrapperDisplay SQL view (Postgres + MySQL) to include h.isSecret AS hashlistIsSecret.
  • Extended TaskWrapperDisplay PHP model + factory to carry/serialize the new hashlistIsSecret field.
  • Updated the DBA model generator config to include the new field.
File summaries
File Description
src/migrations/postgres/20260908100000_task-view-add-hashlist-secret-field.sql Adds hashlistIsSecret column to the Postgres TaskWrapperDisplay view.
src/migrations/mysql/20260908100000_task-view-add-hashlist-secret-field.sql Adds hashlistIsSecret column to the MySQL TaskWrapperDisplay view.
src/dba/models/TaskWrapperDisplayFactory.php Maps the new view column into the TaskWrapperDisplay constructor.
src/dba/models/TaskWrapperDisplay.php Adds the new property, constructor parameter, serialization, and accessor methods.
src/dba/models/generator.php Adds hashlistIsSecret to the generator column list for TaskWrapperDisplay.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/dba/models/TaskWrapperDisplay.php Outdated
Comment thread src/dba/models/generator.php Outdated
@jessevz
jessevz marked this pull request as draft September 8, 2026 17:31
@jessevz
jessevz marked this pull request as ready for review September 10, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: hashlist secret unclear

2 participants