Skip to content

chore: update build_frontend.yml - #71

Merged
nicolas-rabault merged 2 commits into
mainfrom
security-fix/-github-workflows-build_frontend-yml-1784280418
Jul 29, 2026
Merged

chore: update build_frontend.yml#71
nicolas-rabault merged 2 commits into
mainfrom
security-fix/-github-workflows-build_frontend-yml-1784280418

Conversation

@hf-security-analysis

@hf-security-analysis hf-security-analysis Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Update .github/workflows/build_frontend.yml workflow configuration.

cc @dependabot[bot] @nicolas-rabault

Closes huggingface/tracking-issues#864

@hf-security-analysis
hf-security-analysis Bot requested a review from paulinebm July 17, 2026 09:27
@nicolas-rabault

Copy link
Copy Markdown
Member

Pushed a fixup: gh auth login --with-token exits 1 when GH_TOKEN is already in the environment, which it is for this step, so the push would never have run and frontend/dist would silently stop being rebuilt. gh auth setup-git reads the token from the env on its own, so dropping the login line is enough.

@nicolas-rabault
nicolas-rabault force-pushed the security-fix/-github-workflows-build_frontend-yml-1784280418 branch from 3618fc3 to b36be19 Compare July 29, 2026 08:18
hf-security-analysis Bot and others added 2 commits July 29, 2026 13:32
`gh auth login --with-token` exits 1 when GH_TOKEN is already in the
environment, which it is for this step, so the push never ran.
`gh auth setup-git` picks the token up from the env on its own.
@nicolas-rabault
nicolas-rabault force-pushed the security-fix/-github-workflows-build_frontend-yml-1784280418 branch from b36be19 to 39ad46e Compare July 29, 2026 11:32
@nicolas-rabault
nicolas-rabault merged commit a654148 into main Jul 29, 2026
4 checks passed
@nicolas-rabault
nicolas-rabault deleted the security-fix/-github-workflows-build_frontend-yml-1784280418 branch July 29, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant