Skip to content

⚡ Optimize subscriber iteration in notifySubscribers #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstrand merged 3 commits into from
Jul 10, 2026
Merged

⚡ Optimize subscriber iteration in notifySubscribers #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1081c06
perf: optimize forEach loop in squawk notifications
google-labs-jules[bot] Jul 10, 2026
55ab8b1
chore: remove benchmark.ts outside rootDir
google-labs-jules[bot] Jul 10, 2026
1cb61af
Merge branch 'master' into perf-optimize-foreach-7691523417830553353
johnstrand Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Squawk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ export default function createStore<T>(initialState: Required<T>, useReduxDevToo
// We avoid doing forEach(... => { }) because that would recreate the closure for
// each loop, and that causes unnecessary allocations
for (const list of contextSubscribers) {
list.forEach(reduceEach);
for (const subscriber of list) {
reduceEach(subscriber);
}
}
};

Expand Down
Loading