Don't allow redirects when contacting the CTS from NERSC - #740
Merged
Conversation
Had a weird blip where it seemed like a test requestcatcher.com url was redirected to ipv4.games, with an expired cert, which caused the download to NERSC task to fail. Can't reproduce, but disallowing and logging redirects anyway.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=======================================
Coverage 64.36% 64.36%
=======================================
Files 68 68
Lines 6948 6948
=======================================
Hits 4472 4472
Misses 2476 2476 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a weird blip where it seemed like a test requestcatcher.com url was redirected to ipv4.games, with an expired cert, which caused the download to NERSC task to fail. Can't reproduce, but disallowing and logging redirects anyway.